Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused TimeSpokenSince Listener #46

Open
ryannealmes opened this issue Apr 5, 2016 · 0 comments
Open

Unused TimeSpokenSince Listener #46

ryannealmes opened this issue Apr 5, 2016 · 0 comments

Comments

@ryannealmes
Copy link
Collaborator

Can we remove the following code?

// var listenTimeSpokenSince = function(socket) {
//     socket.on("timeSpokenSince", function(data) {
//         winston.log("info", "received timeSpokenSince event");
//         talk_time.time_spoken_since(data.from_time, data.participant_ids, data.hangout_id);
//     });
// };

If this isn't being used could we also remove it from talk_time?

Looking at the code I couldn't see these functions being used anywhere time_spoken_since, total_time_spoken_in_hangout and processes in talk_times.js. These are unnecessarily bloating the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant