env_config: infer HOMEBREW_FORBID_PACKAGES_FROM_PATHS from HOMEBREW_DEVELOPER #18379
Conversation
…EVELOPER If `HOMEBREW_DEVELOPER` is not set, then let's make `HOMEBREW_FORBID_PACKAGES_FROM_PATHS` default to true. I used a custom implementation here because we don't currently support setting defaults for booleans. (See calls to `define_method` below.) Closes #18371.
|
Since this is a breaking change, we may want to save this for a minor release. |
|
Looks like a lot of tests will need fixing. |
| ENVS.fetch(:HOMEBREW_FORBID_PACKAGES_FROM_PATHS) | ||
| .fetch(:default) | ||
| .call |
There was a problem hiding this comment.
| ENVS.fetch(:HOMEBREW_FORBID_PACKAGES_FROM_PATHS) | |
| .fetch(:default) | |
| .call | |
| developer? |
feels a bit nice?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I'll get to this late next week (or in the first half of the week following that). Note: I'm not optimistic about being able to fix the test failures, so I may just end up closing this after working on it again. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?If
HOMEBREW_DEVELOPERis not set, then let's makeHOMEBREW_FORBID_PACKAGES_FROM_PATHSdefault to true.I used a custom implementation here because we don't currently support
setting defaults for booleans. (See calls to
define_methodbelow.)Closes #18371.