Commit f14910b
committed
fix(android): address auto-save SOCKS5 validation, cursor crash, HTTP status checks and dead conditional
- Add SOCKS5 auth validation guard to auto-save LaunchedEffect in SettingsScreen.kt to prevent persisting profiles with only one of socks_user/socks_pass set (regression from removal of Save button).
- Guard getFileNameFromUri in ProfilesScreen.kt with nameIndex >= 0 to prevent CursorIndexOutOfBoundsException when content provider doesn't expose DISPLAY_NAME.
- Check connection.responseCode before reading inputStream in ProfilesViewModel.updateRemoteProfile and importProfileFromUrl, surfacing HTTP errors via errorStream instead of generic IOException.
- Replace dead conditional (selectedProfile.remoteUrl != null was always true after early return) with remoteProfile.name.isNotBlank() in updateRemoteProfile to preserve local name when remote returns blank name.1 parent 2fc9e87 commit f14910b
3 files changed
Lines changed: 18 additions & 2 deletions
File tree
- android/app/src/main/java/com/gooserelay/gooserelayvpn/ui
- profiles
- settings
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
| 192 | + | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| |||
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
90 | 98 | | |
91 | 99 | | |
92 | 100 | | |
93 | 101 | | |
94 | 102 | | |
95 | 103 | | |
96 | | - | |
| 104 | + | |
97 | 105 | | |
98 | 106 | | |
99 | 107 | | |
| |||
128 | 136 | | |
129 | 137 | | |
130 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
131 | 146 | | |
132 | 147 | | |
133 | 148 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
| |||
0 commit comments