Skip to content

Update deploy condition to explicitly limit to the main branch. Envir… #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update deploy condition to explicitly limit to the main branch. Envir… #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ jobs:
needs: build
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
# Only deploy on push to main or manual trigger, not on PRs
if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'workflow_dispatch'
# Only deploy on push to main or manual trigger from main branch, not on PRs
if: github.ref == 'refs/heads/main' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch')
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we had a build workflow that ran on everything, and then a deploy workflow that only ever ran on push to main and used the build workflow as a prereq?

Copy link
Contributor Author

@heskew heskew Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to cleanup the skipped job in every pr workflow :)

I'll do a bit more of an update when I can get a chance.


permissions:
pages: write
Expand Down