chore: pr review

Author: GabrielMartinezRodriguez

apps/iframe/src/components/interface/permissions/useAppsWithPermissions.ts

@@ -1,7 +1,4 @@
-import { entries } from "@happy.tech/common"
 import { use$ } from "@legendapp/state/react"
-import { useAtomValue } from "jotai"
-import { useAccount } from "wagmi"
 import { type AppPermissions, permissionsMapLegend } from "#src/state/permissions"
 import { type AppURL, isWallet } from "#src/utils/appURL"
 

apps/iframe/src/state/permissions.ts

@@ -1,5 +1,4 @@
-import { createUUID } from "@happy.tech/common"
-import type { Address, UUID } from "@happy.tech/common"
+import type { Address } from "@happy.tech/common"
 import { logger } from "@happy.tech/wallet-common"
 import { observable } from "@legendapp/state"
 import { ObservablePersistLocalStorage } from "@legendapp/state/persist-plugins/local-storage"
@@ -51,7 +50,7 @@ export type WalletPermission = {
     // The app to which the permission is granted.
     invoker: AppURL
     // This is the EIP-1193 request that this permission is mapped to.
-    parentCapability: "eth_accounts" | string // TODO only string or make specific
+    parentCapability: string
     caveats: WalletPermissionCaveat[]
     date: number
     // Not in the EIP, but Viem wants this.
@@ -88,14 +87,9 @@ export type SessionKeyRequest = {
  */
 export type PermissionsRequest = string | PermissionRequestObject
 
-type PermissionCheckParams = {
-    permissionsRequest: PermissionsRequest
-    app: AppURL
-}
-
 export const permissionsMapLegend = observable(
     syncedCrud({
-        list: async ({ lastSync }) => {
+        list: async () => {
             const user = getUser()
             if (!user) return []
             const response = await fetch(`http://localhost:3000/api/v1/settings/list?user=${user.address}`)
@@ -125,7 +119,7 @@ export const permissionsMapLegend = observable(
         },
         subscribe: ({ refresh }) => {
             // Set up an interval to refresh messages every 5 seconds
-            const intervalId = setInterval(() => {
+            setInterval(() => {
                 console.log("Refreshing config (5-second interval)")
                 refresh()
             }, 5000)
@@ -352,7 +346,6 @@ export function grantPermissions(app: AppURL, permissionRequest: PermissionsRequ
                 parentCapability: name,
                 date: Date.now(),
                 id,
-                deleted: false,
                 updatedAt: Date.now(),
                 createdAt: Date.now(),
                 type: "WalletPermissions",

apps/settings-service/.env.example

@@ -0,0 +1,3 @@
+NODE_ENV=development
+APP_PORT=3000
+SETTINGS_DB_URL=settings.sqlite

apps/sync-service/.env.example

@@ -5,9 +5,9 @@ include ../../makefiles/formatting.mk
 include ../../makefiles/bundling.mk
 include ../../makefiles/help.mk
 
-start: ## Starts the settings service
+dev: ## Starts the settings service
 	bun run --hot src/index.ts
-.PHONY: start
+.PHONY: dev
 
 migrate: ## Runs pending migrations
 	bun run src/migrate.ts

apps/settings-service/Makefile apps/sync-service/Makefileapps/settings-service/Makefile renamed to apps/sync-service/Makefile

@@ -1,5 +1,5 @@
 {
-    "name": "@happy.tech/settings-service",
+    "name": "@happy.tech/sync-service",
     "private": true,
     "version": "0.1.0",
     "type": "module",
@@ -11,18 +11,14 @@
     },
     "dependencies": {
         "@happy.tech/common": "workspace:0.1.0",
-        "@hono/node-server": "^1.13.8",
         "@scalar/hono-api-reference": "^0.5.175",
         "hono": "^4.7.2",
         "hono-openapi": "^0.4.4",
         "neverthrow": "^8.1.0",
-        "uuid": "^11.1.0",
         "zod": "^3.23.8",
         "zod-openapi": "^4.2.3"
     },
     "devDependencies": {
-        "@happy.tech/happybuild": "workspace:0.1.1",
-        "typescript": "^5.6.2",
-        "hono-openapi": "^0.4.4"
+        "@happy.tech/happybuild": "workspace:0.1.1"
     }
 }