fix(h2): bind routine details to schema

Author: HandSonic

chat2db-community-server/chat2db-community-plugins/chat2db-community-h2/src/main/java/ai/chat2db/plugin/h2/H2Meta.java

@@ -117,7 +117,7 @@ private String getDDL(Connection connection, String databaseName, String schemaN
     public Function function(Connection connection, @NotEmpty String databaseName, String schemaName,
         String functionName) {
 
-        String sql = String.format(ROUTINES_SQL, "FUNCTION", getSQLIdentifierProcessor().escapeString(databaseName),
+        String sql = String.format(ROUTINES_SQL, "FUNCTION", getSQLIdentifierProcessor().escapeString(schemaName),
             getSQLIdentifierProcessor().escapeString(functionName));
         return DefaultSQLExecutor.getInstance().execute(connection, sql, resultSet -> {
             Function function = new Function();
@@ -159,7 +159,7 @@ public List<Trigger> triggers(Connection connection, String databaseName, String
     public Trigger trigger(Connection connection, @NotEmpty String databaseName, String schemaName,
         String triggerName) {
 
-        String sql = String.format(TRIGGER_SQL, getSQLIdentifierProcessor().escapeString(databaseName),
+        String sql = String.format(TRIGGER_SQL, getSQLIdentifierProcessor().escapeString(schemaName),
             getSQLIdentifierProcessor().escapeString(triggerName));
         return DefaultSQLExecutor.getInstance().execute(connection, sql, resultSet -> {
             Trigger trigger = new Trigger();
@@ -176,7 +176,7 @@ public Trigger trigger(Connection connection, @NotEmpty String databaseName, Str
     @Override
     public Procedure procedure(Connection connection, @NotEmpty String databaseName, String schemaName,
         String procedureName) {
-        String sql = String.format(ROUTINES_SQL, "PROCEDURE", getSQLIdentifierProcessor().escapeString(databaseName),
+        String sql = String.format(ROUTINES_SQL, "PROCEDURE", getSQLIdentifierProcessor().escapeString(schemaName),
             getSQLIdentifierProcessor().escapeString(procedureName));
         return DefaultSQLExecutor.getInstance().execute(connection, sql, resultSet -> {
             Procedure procedure = new Procedure();

chat2db-community-server/chat2db-community-plugins/chat2db-community-h2/src/test/java/ai/chat2db/plugin/h2/H2MetaSchemaBindingTest.java

@@ -0,0 +1,60 @@
+package ai.chat2db.plugin.h2;
+
+import org.junit.jupiter.api.Test;
+
+import java.lang.reflect.Proxy;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class H2MetaSchemaBindingTest {
+
+    @Test
+    void routineAndTriggerDetailsFilterBySchemaInsteadOfCatalog() {
+        List<String> sql = new ArrayList<>();
+        Connection connection = connection(sql);
+        H2Meta metaData = new H2Meta();
+
+        metaData.function(connection, "CATALOG", "APP", "F1");
+        metaData.procedure(connection, "CATALOG", "APP", "P1");
+        metaData.trigger(connection, "CATALOG", "APP", "T1");
+
+        assertTrue(sql.get(0).contains("ROUTINE_SCHEMA ='APP'"), sql.get(0));
+        assertTrue(sql.get(1).contains("ROUTINE_SCHEMA ='APP'"), sql.get(1));
+        assertTrue(sql.get(2).contains("TRIGGER_SCHEMA = 'APP'"), sql.get(2));
+    }
+
+    private static Connection connection(List<String> sql) {
+        ResultSet resultSet = (ResultSet) Proxy.newProxyInstance(
+            H2MetaSchemaBindingTest.class.getClassLoader(),
+            new Class<?>[]{ResultSet.class},
+            (proxy, method, args) -> switch (method.getName()) {
+                case "next" -> false;
+                case "close" -> null;
+                default -> throw new AssertionError("Unexpected ResultSet call: " + method.getName());
+            });
+        return (Connection) Proxy.newProxyInstance(
+            H2MetaSchemaBindingTest.class.getClassLoader(),
+            new Class<?>[]{Connection.class},
+            (proxy, method, args) -> {
+                if (!"prepareStatement".equals(method.getName())) {
+                    throw new AssertionError("Unexpected Connection call: " + method.getName());
+                }
+                sql.add((String) args[0]);
+                return Proxy.newProxyInstance(
+                    H2MetaSchemaBindingTest.class.getClassLoader(),
+                    new Class<?>[]{PreparedStatement.class},
+                    (statement, statementMethod, statementArgs) -> switch (statementMethod.getName()) {
+                        case "execute" -> true;
+                        case "getResultSet" -> resultSet;
+                        case "close" -> null;
+                        default -> throw new AssertionError(
+                            "Unexpected PreparedStatement call: " + statementMethod.getName());
+                    });
+            });
+    }
+}