-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In future trim down custom metrics from payload
?
#269
Comments
payload
payload
?
Code has been added but commented out. Just need to remove the comment block when we're ready to remove them. |
FWIW, it's probably a fairly substantial size. the rendered_html metric in particular (as well as the CSS ones) can be multiple megabytes. |
Yeah exactly! We could still inject them into the payload when populating the I’ve updated all the httparchvie queries not to look at custom metrics in the legacy |
As part of the effort to reduce the payload since by deduplicating data we remove the
_custom
field (amongst others) when saving this data toall
tables:https://github.com/HTTPArchive/wptagent/blob/e4546673d3b658022afb3885885e696290da53c5/HTTPArchive/httparchive.py#L425-L427
However, that is only a list of the custom metrics:
The more weighty parts are the actual custom metrics beaneath this (
_00_reset
,_Colordepth
...etc), some of which are quite large.So we should enhance this to remove those too to save a lot of weight.
However, for now, them being in there is useful for the legacy tables (since there is no legacy custom metrics table) so leave for now. But filing this issue for when we move off of legacy so we don't forget.
The text was updated successfully, but these errors were encountered: