Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: Multiple instances of Three.js being imported. #655

Open
EdwardMoyse opened this issue Mar 25, 2024 · 4 comments
Open

WARNING: Multiple instances of Three.js being imported. #655

EdwardMoyse opened this issue Mar 25, 2024 · 4 comments

Comments

@EdwardMoyse
Copy link
Collaborator

when opening e.g. https://hepsoftwarefoundation.org/phoenix/#/lhcb (but any phoenix instance will show it), I see the following in the log:

WARNING: Multiple instances of Three.js being imported.

This message has been there for ages but apparently this can cause issues such as mem leaks, performance issues, and other undefined behaviour ... so I think we should fix it

@9inpachi
Copy link
Collaborator

9inpachi commented Mar 25, 2024 via email

@EdwardMoyse
Copy link
Collaborator Author

Ah seems likely:
https://github.com/root-project/jsroot/blob/7a64fb096d51bfa7e87bf36789e0206f78b08d4c/libs/three/package.json

So, there's not much we can do about this. :-(

@DraTeots
Copy link
Collaborator

Found this on threejs

mrdoob/three.js#25681

But not sure it is used here. Could this help in Phoenix case?

@EdwardMoyse
Copy link
Collaborator Author

Found this on threejs

mrdoob/three.js#25681

But not sure it is used here. Could this help in Phoenix case?

Unfortunately I think in this case it really is from jsroot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants