Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] 탭바 #103

Open
wants to merge 9 commits into
base: renewal
Choose a base branch
from
Open

[Redesign] 탭바 #103

wants to merge 9 commits into from

Conversation

Chaeho-Min
Copy link
Member

@Chaeho-Min Chaeho-Min commented Feb 11, 2023

개요

작업내용

  • 탭바 아이콘 에셋 추가
  • 탭바 타이틀 로컬라이제이션
  • 새 디자인 적용
  • 에셋 같은거 관리할 폴더가 또 필요할거 같아서 Design 폴더를 만들고 Color 폴더를 Design 폴더 안으로 이동시켰습니다.
    • 원래 PR올리려고 코딩하던게 아니라서 막 바꿨는데 그냥 PR을 올리게 돼서 폴더구조 변경한거 그대로 올렸는데 이상하면 다시 돌려놓겠습니다
작업 전 작업 후

리뷰포인트

  • 탭바 높이 조정
    • UITabBar 클래스를 상속한 CustomHeightTabBar 클래스를 만들고
    • UITabBarController에서 CustomHeightTabBar를 사용하도록 함
      init() {
          super.init(nibName: nil, bundle: nil)
          object_setClass(self.tabBar, CustomHeightTabBar.self) // 코드베이스에서 커스텀 클래스를 사용하는 방법
      }
  • 색깔은 나중에 따로 정리하겠습니다

Reference

기타

그냥 심심해서 리디자인한거 코딩해보다가 PR 올리게 된거라 일단 머지 금지 브랜치 따로 파놔서 머지해도 됩니다
다음 회의 때 리디자인 추진 여부랑 일정 정해서 진행합시다

@Chaeho-Min Chaeho-Min self-assigned this Feb 11, 2023
@Chaeho-Min Chaeho-Min linked an issue Feb 11, 2023 that may be closed by this pull request
@Chaeho-Min Chaeho-Min changed the base branch from setting/62-foldering to renewal February 11, 2023 12:04
@Chaeho-Min Chaeho-Min changed the title [Redesign] 탭바 🚨머지금지!!🚨 [Redesign] 탭바 Feb 11, 2023
Copy link
Collaborator

@chaneeii chaneeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +10 to +17
enum TabbarIcons: String {
case todaySelected = "Today_selected"
case todayUnselected = "Today_unselected"
case recordSelected = "Record_selected"
case recordUnselected = "Record_unselected"
case storageSelected = "Storage_selected"
case storageUnselected = "Storage_unselected"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

리디자인 - 탭바
2 participants