Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FadeMod corner cases. #203

Open
Hoikas opened this issue Sep 20, 2020 · 2 comments
Open

FadeMod corner cases. #203

Hoikas opened this issue Sep 20, 2020 · 2 comments
Assignees

Comments

@Hoikas
Copy link
Member

Hoikas commented Sep 20, 2020

The fade mod has the following corner cases and design issues:

  • plFadeOpacityMod back fade mods need to have a coordinate interface, otherwise, the fade is calculated from the LOS to the origin. Currently, this is not enforced.
  • The simple distance tip is wrong. plDistOpacityMod fades objects out as you move closer.
  • Given the previous, we need a way to do fade in using icicles.
  • kTrackCamera is not exposed for plDistOpacityMod based faders - meaning the avatar transform is used for fades.
  • The warning about distances is erroneously displayed in LOS mode.
@dpogue
Copy link
Member

dpogue commented Sep 20, 2020

Fading things in probably requires using LOD (setting the fMinDist and fMaxDist in the plIcicles for each object)

@dpogue
Copy link
Member

dpogue commented Apr 28, 2021

Took a bit closer look at how this is handled in PlasmaMax.

  • plFadeOpacityMod is working fine (probably with the caveat you mentioned about needing a CI)
  • plDistOpacityMod seems to only ever be used by GZ markers, and in PlasmaMax is actually labelled as "GZ Fade"
  • Fading objects in over distance is done by setting in MinDist and MaxDist on the geoSpan for the object

Maybe we just want to change the "Simple Distance Fade" mode to set the icicle stuff, and leave the complicated distance stuff to plDistOpacityMod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants