refactor(core): improvements on constraints & tests

Author: Guikingone

src/Test/Constraint/Probe/ProbeExecutedTask.php

@@ -30,6 +30,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof ProbeInterface) {
+            return false;
+        }
+
         return $this->expectedCount === $other->getExecutedTasks();
     }
 }

src/Test/Constraint/Probe/ProbeFailedTask.php

@@ -30,6 +30,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof ProbeInterface) {
+            return false;
+        }
+
         return $this->expectedCount === $other->getFailedTasks();
     }
 }

src/Test/Constraint/Probe/ProbeScheduledTask.php

@@ -6,6 +6,8 @@
 
 use PHPUnit\Framework\Constraint\Constraint;
 use SchedulerBundle\Probe\ProbeInterface;
+use SchedulerBundle\SchedulerInterface;
+use Throwable;
 use function sprintf;
 
 /**
@@ -27,9 +29,15 @@ public function toString(): string
 
     /**
      * @param mixed|ProbeInterface $other
+     *
+     * @throws Throwable {@see SchedulerInterface::getTasks()}
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof ProbeInterface) {
+            return false;
+        }
+
         return $this->expectedCount === $other->getScheduledTasks();
     }
 }

src/Test/Constraint/Probe/ProbeState.php

@@ -34,6 +34,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof ProbeInterface) {
+            return false;
+        }
+
         return $this->expectedState === [
             'executedTasks' => $other->getExecutedTasks(),
             'failedTasks' => $other->getFailedTasks(),

src/Test/Constraint/Scheduler/SchedulerDueTask.php

@@ -6,6 +6,7 @@
 
 use PHPUnit\Framework\Constraint\Constraint;
 use SchedulerBundle\SchedulerInterface;
+use Throwable;
 use function sprintf;
 
 /**
@@ -27,9 +28,15 @@ public function toString(): string
 
     /**
      * @param mixed|SchedulerInterface $other
+     *
+     * @throws Throwable {@see SchedulerInterface::getDueTasks()}
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof SchedulerInterface) {
+            return false;
+        }
+
         return $this->expectedCount === $other->getDueTasks()->count();
     }
 }

src/Test/Constraint/TaskExecuted.php

@@ -32,6 +32,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof TaskEventList) {
+            return false;
+        }
+
         return $this->expectedCount === $this->countExecutedTasks($other);
     }
 

src/Test/Constraint/TaskFailed.php

@@ -7,7 +7,6 @@
 use PHPUnit\Framework\Constraint\Constraint;
 use SchedulerBundle\Event\TaskEventList;
 use function count;
-use function is_countable;
 use function sprintf;
 
 /**
@@ -32,6 +31,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
-        return $this->expectedCount === (is_countable($other->getFailedTaskEvents()) ? count($other->getFailedTaskEvents()) : 0);
+        if (!$other instanceof TaskEventList) {
+            return false;
+        }
+
+        return $this->expectedCount === count($other->getFailedTaskEvents());
     }
 }

src/Test/Constraint/TaskQueued.php

@@ -31,6 +31,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
+        if (!$other instanceof TaskEventList) {
+            return false;
+        }
+
         return $this->expectedCount === $this->countQueuedTasks($other);
     }
 

src/Test/Constraint/TaskScheduled.php

@@ -31,6 +31,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
-        return $this->expectedCount === (is_countable($other->getScheduledTaskEvents()) ? count($other->getScheduledTaskEvents()) : 0);
+        if (!$other instanceof TaskEventList) {
+            return false;
+        }
+
+        return $this->expectedCount === count($other->getScheduledTaskEvents());
     }
 }

src/Test/Constraint/TaskUnscheduled.php

@@ -31,6 +31,10 @@ public function toString(): string
      */
     protected function matches($other): bool
     {
-        return $this->expectedCount === (is_countable($other->getUnscheduledTaskEvents()) ? count($other->getUnscheduledTaskEvents()) : 0);
+        if (!$other instanceof TaskEventList) {
+            return false;
+        }
+
+        return $this->expectedCount === count($other->getUnscheduledTaskEvents());
     }
 }