Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opensrv Use After Free update #4732

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Sep 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4696

What's changed and what's your intention?

  • update opensrv to fix a uaf in it's code(test write large sql using mysql protocol on my local machine can now work without panic), also update a few other crates due to version skew.
  • also add calls to provide CryptoProvider using ring in every related tests and in main fn of greptime binary
  • make aws-lc-rs use prebuilt-nasm on windows to prevent need to install nasm assembler on windows for compile

Possible change to unrelated part of code

A concern is that after update rustls from 0.22 to 0.23 it now use aws-lc as default crypto lib, but it require nasm assembler on windows.
so for now I just use rustls = { version = "0.23", default-features = false, features = ["ring", "logging", "std", "tls12"] } for the old ring lib
this behavior might need to change in the future. (Now both features are activate due to depend like opensrv enabled aws-lc-rs feature of rustls and cargo unify both features and enabled them both)
Edited: now some tests related to tls seems to failing too Fixed by providing CryptoProvider using ring in every related tests** and call install ring provider in greptime-bin's main fn

See more in sunng87/pgwire@a673412 and
https://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html#using-the-per-process-default-cryptoprovider

Checklist

  • This PR await this PR in opensrv repo to merge, currently it just depend on my own fork Now merged
  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@discord9 discord9 requested a review from a team as a code owner September 18, 2024 07:05
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Sep 18, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (36b1baf) to head (b0d3fec).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4732      +/-   ##
==========================================
- Coverage   84.79%   84.63%   -0.16%     
==========================================
  Files        1115     1117       +2     
  Lines      201200   201340     +140     
==========================================
- Hits       170598   170402     -196     
- Misses      30602    30938     +336     

@sunng87 sunng87 enabled auto-merge September 19, 2024 03:56
@sunng87 sunng87 disabled auto-merge September 19, 2024 04:00
@sunng87 sunng87 enabled auto-merge September 19, 2024 04:05
@sunng87 sunng87 added this pull request to the merge queue Sep 19, 2024
@sunng87 sunng87 linked an issue Sep 19, 2024 that may be closed by this pull request
Merged via the queue into GreptimeTeam:main with commit d1e0602 Sep 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade rustls family to 0.23
4 participants