-
Notifications
You must be signed in to change notification settings - Fork 324
Closed
Labels
Description
Checked for existing issues
- I have checked for existing issues, and have found none.
Tested latest version
- I have checked that this occurs on the latest version.
GregTech CEu Version
v7.4.0-1.20.1
Minecraft Version
1.20.1 Forge
Recipe Viewer Installed
None
Environment
Singleplayer
Cross-Mod Interaction
No
Other Installed Mods
None
Expected Behavior
The primitive pump should produce 350mb of water in a jungle biome as shown here
Actual Behavior
It produces 800mb of water in jungle biomes
Steps to Reproduce
Place a primitive pump in a jungle biome
Additional Information
This is the relevant code
} else if (biome.is(Tags.Biomes.IS_SWAMP) || biome.is(Tags.Biomes.IS_WET)) {
return FluidType.BUCKET_VOLUME * 4 / 5;
} else if (biome.is(BiomeTags.IS_JUNGLE)) {
return FluidType.BUCKET_VOLUME * 35 / 100;The check for IS_WET is done before the check for IS_JUNGLE
all the IS_JUNGLE biomes are in IS_WET
so any situation where the second condition would succeed so does the first
as a result jungle biomes produce 800mb instead of 350mb