Skip to content

Commit b6c93bf

Browse files
committed
Fix tests
1 parent 181e249 commit b6c93bf

File tree

5 files changed

+35
-5
lines changed

5 files changed

+35
-5
lines changed

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/FilteringTest.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ class FilteringTest : BasePluginTest() {
118118
assertThat(outputShadowJar).useAll {
119119
containsOnly(
120120
"d.properties",
121+
"my/",
121122
"my/Passed.class",
122123
*manifestEntries,
123124
includeDirs = true,
@@ -164,6 +165,8 @@ class FilteringTest : BasePluginTest() {
164165

165166
assertThat(outputServerShadowJar).useAll {
166167
containsOnly(
168+
"client/",
169+
"server/",
167170
"client/Client.class",
168171
"server/Server.class",
169172
*manifestEntries,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginTest.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,16 +156,21 @@ class JavaPluginTest : BasePluginTest() {
156156

157157
assertThat(jarPath("server/build/libs/server-1.0.jar")).useAll {
158158
containsOnly(
159+
"server/",
159160
"server/Server.class",
160161
*manifestEntries,
161162
includeDirs = true,
162163
)
163164
}
164165
assertThat(jarPath("client/build/libs/client-1.0-all.jar")).useAll {
165166
containsAtLeast(
167+
"client/",
166168
"client/Client.class",
167169
"client/junit/framework/Test.class",
168170
)
171+
containsNone(
172+
"server/Server.class",
173+
)
169174
}
170175
}
171176

@@ -257,6 +262,7 @@ class JavaPluginTest : BasePluginTest() {
257262

258263
assertThat(outputShadowJar).useAll {
259264
containsOnly(
265+
"my/",
260266
"my/Passed.class",
261267
"a.properties",
262268
"META-INF/a.properties",
@@ -491,6 +497,9 @@ class JavaPluginTest : BasePluginTest() {
491497
getMainAttr(classPathAttributeKey).isNull()
492498

493499
containsOnly(
500+
"my/",
501+
"my/plugin/",
502+
"META-INF/gradle-plugins/",
494503
"my/plugin/MyPlugin.class",
495504
"META-INF/gradle-plugins/my.plugin.properties",
496505
*entriesInA,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/MinimizationTest.kt

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ class MinimizationTest : BasePluginTest() {
5959

6060
assertThat(jarPath("impl/build/libs/impl-all.jar")).useAll {
6161
containsOnly(
62+
"api/",
63+
"impl/",
64+
"lib/",
6265
"impl/SimpleEntity.class",
6366
"api/Entity.class",
6467
"api/UnusedEntity.class",
@@ -220,13 +223,17 @@ class MinimizationTest : BasePluginTest() {
220223

221224
assertThat(outputServerShadowJar).useAll {
222225
if (enable) {
223-
containsOnly(
226+
containsAtLeast(
224227
"server/Server.class",
225-
*manifestEntries,
226-
includeDirs = true,
228+
manifestEntry,
229+
)
230+
containsNone(
231+
"client/Client.class",
227232
)
228233
} else {
229234
containsOnly(
235+
"client/",
236+
"server/",
230237
"client/Client.class",
231238
"server/Server.class",
232239
*junitEntries,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/RelocationTest.kt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.github.jengelman.gradle.plugins.shadow
33
import assertk.assertFailure
44
import assertk.assertThat
55
import assertk.assertions.contains
6-
import assertk.assertions.containsOnly
76
import assertk.assertions.isEmpty
87
import assertk.assertions.isInstanceOf
98
import assertk.assertions.isNotEmpty
@@ -316,6 +315,7 @@ class RelocationTest : BasePluginTest() {
316315

317316
assertThat(outputShadowJar).useAll {
318317
containsOnly(
318+
"bar/",
319319
"bar/Foo.class",
320320
"bar/foo.properties",
321321
"bar/dep.properties",
@@ -510,10 +510,14 @@ class RelocationTest : BasePluginTest() {
510510
includeDirs = true,
511511
)
512512
} else {
513-
containsOnly(
513+
containsAtLeast(
514514
"foo/$manifestEntry",
515515
*junitEntries.map { "foo/$it" }.toTypedArray(),
516516
)
517+
containsNone(
518+
*junitEntries,
519+
manifestEntry,
520+
)
517521
}
518522
}
519523
}
@@ -567,13 +571,16 @@ class RelocationTest : BasePluginTest() {
567571
assertThat(outputShadowJar).useAll {
568572
if (enableRelocation) {
569573
containsOnly(
574+
"my/",
575+
"$relocationPrefix/",
570576
mainClassEntry,
571577
*relocatedEntries,
572578
*manifestEntries,
573579
includeDirs = true,
574580
)
575581
} else {
576582
containsOnly(
583+
"my/",
577584
mainClassEntry,
578585
*junitEntries,
579586
*manifestEntries,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/caching/FilteringCachingTest.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ class FilteringCachingTest : BaseCachingTest() {
9898

9999
assertCompositeExecutions {
100100
containsOnly(
101+
"my/",
101102
mainClassEntry,
102103
main2ClassEntry,
103104
*manifestEntries,
@@ -115,6 +116,7 @@ class FilteringCachingTest : BaseCachingTest() {
115116

116117
assertCompositeExecutions {
117118
containsOnly(
119+
"my/",
118120
mainClassEntry,
119121
*manifestEntries,
120122
includeDirs = true,
@@ -131,6 +133,7 @@ class FilteringCachingTest : BaseCachingTest() {
131133

132134
assertCompositeExecutions {
133135
containsOnly(
136+
"my/",
134137
mainClassEntry,
135138
main2ClassEntry,
136139
*manifestEntries,
@@ -169,6 +172,7 @@ class FilteringCachingTest : BaseCachingTest() {
169172

170173
assertCompositeExecutions {
171174
containsOnly(
175+
"my/",
172176
mainClassEntry,
173177
*manifestEntries,
174178
includeDirs = true,

0 commit comments

Comments
 (0)