Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Endpoint for import History #373

Merged
merged 3 commits into from
Jan 20, 2023
Merged

API Endpoint for import History #373

merged 3 commits into from
Jan 20, 2023

Conversation

amrro
Copy link
Collaborator

@amrro amrro commented Jan 17, 2023 •
edited
Loading

Linear Ticket

ENG-665 - API Endpoint for import History

Description

  • Add ImportStatus enum to GuildImport table.
  • Link GuildUser to the GuildImport table.
  • Rename membershipStatus -> membership_status to align with naming
    convention & update usages.
  • Add import history API.

Usage

    govrnProtocol.guild.import
      .list({})
      .then(value => {
        console.log(value);
      })
      .catch(e => console.error(e));

@amrro amrro force-pushed the imports-status-members branch from efcf565 to 8a2433f Compare January 18, 2023 12:55
@amrro
Copy link
Collaborator Author

amrro commented Jan 18, 2023

Update #364 After merge.

alexkeating
alexkeating reviewed Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request 🙏

amrro added 3 commits January 19, 2023 16:52
@amrro
Add Prisma migration
c486cff 
- Add `ImportStatus` enum to `GuildImport` table.
- Link `GuildUser` to the `GuildImport` table.
- Rename `membershipStatus` -> `membership_status` to align with naming
  rules & update usages
- run generate:gql & prisma migrate.
@amrro
Add list guild imports API
fe67502
@amrro
Revert membership status column renaming
728cac0
@amrro amrro force-pushed the imports-status-members branch from 3d1a6a3 to 728cac0 Compare January 19, 2023 15:34
@amrro amrro requested a review from alexkeating January 19, 2023 16:05
@alexkeating alexkeating merged commit b7b32ca into staging Jan 20, 2023
@alexkeating alexkeating deleted the imports-status-members branch January 20, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanprozzi jonathanprozzi Awaiting requested review from jonathanprozzi

@alexkeating alexkeating Awaiting requested review from alexkeating

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrro @alexkeating