Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/csv uploader #358

Draft
wants to merge 15 commits into
base: staging
Choose a base branch
from
Draft

Feature/csv uploader #358

wants to merge 15 commits into from

Conversation

alexkeating
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But looks fine so far, we can probably follow on refactor to reorganize the code

const data = sc.decode(msg.data);
console.log('processing message...');
// DAO ID, address, discord name/username (optional), dicord_id (optional ), admin
const [daoId, address, discordName, discordId, admin] = data.split(',');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably wrong in the ticket but we should probably remove id

@amrro amrro mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants