Support TemplateField for build.artifacts.docker.cliFlags #9582
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
louisjimenez
reviewed
Dec 6, 2024
| @@ -106,6 +106,12 @@ func (b *Builder) dockerCLIBuild(ctx context.Context, out io.Writer, name string | |||
| if err != nil { | |||
| return "", fmt.Errorf("unable to evaluate build args: %w", err) | |||
| } | |||
| for i, cliFlag := range a.CliFlags { | |||
There was a problem hiding this comment.
Is this something that can be moved to where the other cli args are built: https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/docker/image.go#L629? I believe that would also add support for the GCB case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9581
Description
Upon installing Docker Buildx, the docker build command becomes an alias for docker buildx build. This means that any subsequent docker build commands will be executed using the more advanced features provided by Buildx. Specifically, we intend to leverage the
--cache-to=type=registry,ref=repo/image:tagflag within these commands. In order to several registry, I want to TemplateField for build.artifacts.docker.cliFlags as following.User facing changes (remove if N/A)
User can use TemplateField in cliFlags.