Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kokoro: not all tests being run #1527

Open
glasnt opened this issue Jan 29, 2025 · 0 comments
Open

kokoro: not all tests being run #1527

glasnt opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
samples Issues that are directly related to samples.

Comments

@glasnt
Copy link
Contributor

glasnt commented Jan 29, 2025

Debugging #1525, I discovered that the tests being based on the logic in .toys/kokoro-ci.rb may only include Gemfiles one and two levels deep.

This means that there are a number of tests in deeper nested directories that aren't being run.

My debugging in changing the Gemfile glob to Dir.glob("*/**/Gemfile").each (ignoring the top level Gemfile) gives more tests to execute (but also more failures).

Internal details b/392885740#comment6

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

No branches or pull requests

2 participants