Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize ACM IAM tests #12284

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Serialize ACM IAM tests #12284

merged 2 commits into from
Nov 11, 2024

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Nov 8, 2024

Fixes hashicorp/terraform-provider-google#17371

As mentioned in the bug, this test failure is extremely rare. Best guess is a race condition, and since all other ACM tests are serialized already anyway, these probably should be too.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 10 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 10 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager

🟢 All tests passed!

View the build log

@roaks3 roaks3 requested review from a team and NickElliot and removed request for a team November 8, 2024 20:13
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…rce_access_context_manager_access_policy_test.go.tmpl

Co-authored-by: Nick Elliot <[email protected]>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 10 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 10 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager

🟢 All tests passed!

View the build log

@roaks3 roaks3 merged commit 1429328 into main Nov 11, 2024
14 checks passed
@roaks3 roaks3 deleted the serial-acm-iam-tests branch November 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccAccessContextManagerAccessPolicyIam*
3 participants