-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize ACM IAM tests #12284
Serialize ACM IAM tests #12284
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...orm/services/accesscontextmanager/resource_access_context_manager_access_policy_test.go.tmpl
Outdated
Show resolved
Hide resolved
…rce_access_context_manager_access_policy_test.go.tmpl Co-authored-by: Nick Elliot <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Fixes hashicorp/terraform-provider-google#17371
As mentioned in the bug, this test failure is extremely rare. Best guess is a race condition, and since all other ACM tests are serialized already anyway, these probably should be too.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.