Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix wrong iam auth flag for sql_user #12282

Merged

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Nov 8, 2024

This PR was incorrect #10728

Flags are slightly inconsistent between MySQL and Postgres.

This fixes the flag for the Postgres example.

image

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudsql: fixed example in doc using wrong iam auth flag for PostgresQL in `google_sql_user`

This PR was incorrect
GoogleCloudPlatform#10728

Flags are slightly inconsistent between MySQL and Postgres.

This fixes the flag for the Postgres example.
Copy link

google-cla bot commented Nov 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 8, 2024
@eliecharra eliecharra marked this pull request as ready for review November 8, 2024 11:22
Copy link

github-actions bot commented Nov 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@wyardley
Copy link
Contributor

wyardley commented Nov 8, 2024

I think I ran into this in the past, and was a pain to notice the difference, so thanks for fixing!

@modular-magician modular-magician added service/sqladmin-infra and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@shuyama1 shuyama1 merged commit 25fe858 into GoogleCloudPlatform:main Nov 8, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants