Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: updated tests to allow VCR #12280

Merged

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Nov 8, 2024

Followup to #12152

Updated all tests (other than the one testing random instance name generation itself) to use name as well as display_name, and to use tf-test and a random suffix, to follow the regular name generation pattern (both for sweepers, and to make VCR function)

Use smaller size for economy on some tests.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Updated all tests (other than the one testing random instance name
generation itself) to use `name` as well as `display_name`, and to use
`tf-test` and a random suffix, to follow the regular name generation
pattern (both for sweepers, and to make VCR function)

Use smaller size for economy on some tests.
Copy link

github-actions bot commented Nov 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 8, 2024
@modular-magician modular-magician added service/spanner and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 3 files changed, 38 insertions(+), 33 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 35
Passed tests: 20
Skipped tests: 6
Affected tests: 9

Click here to see the affected service packages
  • spanner

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceSpannerInstance_basic
  • TestAccSpannerDatabase_deletionProtection
  • TestAccSpannerInstance_basic
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate
  • TestAccSpannerInstance_update
  • TestAccSpannerInstance_virtualUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceSpannerInstance_basic [Debug log]
TestAccSpannerDatabase_deletionProtection [Debug log]
TestAccSpannerInstance_basic [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate [Debug log]
TestAccSpannerInstance_update [Debug log]
TestAccSpannerInstance_virtualUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these issues!

@SarahFrench
Copy link
Collaborator

(Waiting before merging as there's currently a blocker on merging new contributions)

@SarahFrench SarahFrench merged commit b90cb18 into GoogleCloudPlatform:main Nov 8, 2024
13 checks passed
@wyardley wyardley deleted the wyardley/spanner_vcrskip branch November 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants