-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanner: updated tests to allow VCR #12280
spanner: updated tests to allow VCR #12280
Conversation
Updated all tests (other than the one testing random instance name generation itself) to use `name` as well as `display_name`, and to use `tf-test` and a random suffix, to follow the regular name generation pattern (both for sweepers, and to make VCR function) Use smaller size for economy on some tests.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 35 Click here to see the affected service packages
Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these issues!
(Waiting before merging as there's currently a blocker on merging new contributions) |
Followup to #12152
Updated all tests (other than the one testing random instance name generation itself) to use
name
as well asdisplay_name
, and to usetf-test
and a random suffix, to follow the regular name generation pattern (both for sweepers, and to make VCR function)Use smaller size for economy on some tests.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.