-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support skip_test option in yaml file #12273
base: main
Are you sure you want to change the base?
Conversation
Reassigning to @melinath to ensure this is the way to go. Not sure if there are additional documentation needed around this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. I don't think we have an obvious place for docs about this to live at the moment but we can add that separately / later.
cc @shuyama1
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like gofmt is failing
Done, seems some trailing whitespace on the comment line. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
hashicorp/terraform-provider-google#13623
Support a skip_test option in the yaml file, similar to skip_vcr.
If skip_test var is not an empty string, then the test is generated with a t.Skip("xxx").
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.