Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support skip_test option in yaml file #12273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iyabchen
Copy link
Collaborator

@iyabchen iyabchen commented Nov 7, 2024

hashicorp/terraform-provider-google#13623

Support a skip_test option in the yaml file, similar to skip_vcr.
If skip_test var is not an empty string, then the test is generated with a t.Skip("xxx").

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@iyabchen iyabchen requested review from a team and ScottSuarez and removed request for a team November 7, 2024 19:26
@ScottSuarez ScottSuarez requested review from melinath and removed request for ScottSuarez November 8, 2024 18:13
@ScottSuarez
Copy link
Contributor

Reassigning to @melinath to ensure this is the way to go. Not sure if there are additional documentation needed around this.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. I don't think we have an obvious place for docs about this to live at the moment but we can add that separately / later.

cc @shuyama1

mmv1/api/resource/examples.go Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like gofmt is failing

@iyabchen
Copy link
Collaborator Author

looks like gofmt is failing

Done, seems some trailing whitespace on the comment line.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants