-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TF support for LocalSsdEncryptionMode flag #12249
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/services/container/node_config.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_node_pool_test.go.tmpl
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/node_config.go.tmpl
Outdated
Show resolved
Hide resolved
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Running tests before merging, but I don't anticipate any surprises. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
Ah, we're waiting for field availability in the client. Dismissing review until that's ready. |
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
Add terraform support for local_ssd_encryption_mode on cluster/nodepool create.
Release Note Template for Downstream PRs (will be copied)