Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TF support for LocalSsdEncryptionMode flag #12249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

halimsam
Copy link

@halimsam halimsam commented Nov 5, 2024

Add terraform support for local_ssd_encryption_mode on cluster/nodepool create.

Release Note Template for Downstream PRs (will be copied)

container: added `local_ssd_encryption_mode` to `node_config` in `google_container_cluster` and `google_container_node_pool`

Copy link

github-actions bot commented Nov 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 5, 2024
Copy link

github-actions bot commented Nov 8, 2024

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

rileykarson
rileykarson previously approved these changes Nov 8, 2024
@rileykarson
Copy link
Member

Running tests before merging, but I don't anticipate any surprises.

@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 137 insertions(+), 2 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContainerCluster_withLocalSsdEncryptionMode
  • TestAccContainerNodePool_withLocalSsdEncryptionMode
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@rileykarson
Copy link
Member

Ah, we're waiting for field availability in the client. Dismissing review until that's ready.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants