Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataproc batch convert #11775

Open
wants to merge 1 commit into
base: FEATURE-BRANCH-rewrite-switchover-preview
Choose a base branch
from

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 3623 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 10 files changed, 3626 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 700 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_batch (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_batch" "primary" {
  spark_sql_batch {
    query_variables = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4096
Passed tests: 3671
Skipped tests: 411
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestCloudDataprocBatchRuntimeConfigVersionDiffSuppress

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocAutoscalingPolicyIamBindingGenerated
  • TestAccDataprocAutoscalingPolicyIamMemberGenerated
  • TestAccDataprocAutoscalingPolicyIamPolicyGenerated
  • TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyBasicExample
  • TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyExample
  • TestAccDataprocBatch_dataprocBatchPysparkExample
  • TestAccDataprocBatch_dataprocBatchSparkExample
  • TestAccDataprocBatch_dataprocBatchSparkFullExample
  • TestAccDataprocBatch_dataprocBatchSparkrExample
  • TestAccDataprocBatch_dataprocBatchSparksqlExample
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccDataprocWorkflowTemplate_basic
  • TestAccDataprocWorkflowTemplate_withShieldedVMs
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample

Get to know how VCR tests work

@zli82016 zli82016 changed the base branch from main to FEATURE-BRANCH-rewrite-switchover-preview September 20, 2024 18:11
@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocAutoscalingPolicyIamBindingGenerated[Debug log]
TestAccDataprocAutoscalingPolicyIamMemberGenerated[Debug log]
TestAccDataprocAutoscalingPolicyIamPolicyGenerated[Debug log]
TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyBasicExample[Debug log]
TestAccDataprocAutoscalingPolicy_dataprocAutoscalingPolicyExample[Debug log]
TestAccDataprocBatch_dataprocBatchSparkExample[Debug log]
TestAccDataprocWorkflowTemplate_basic[Debug log]
TestAccDataprocWorkflowTemplate_withShieldedVMs[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocBatch_dataprocBatchPysparkExample[Error message] [Debug log]
TestAccDataprocBatch_dataprocBatchSparkFullExample[Error message] [Debug log]
TestAccDataprocBatch_dataprocBatchSparkrExample[Error message] [Debug log]
TestAccDataprocBatch_dataprocBatchSparksqlExample[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@zli82016
Copy link
Member Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants