adding new google_secure_source_manager_branch_rule resource

[sawaiba-s]

Adds a new google_secure_source_manager_branch_rule resource with tests.

Release Note Template for Downstream PRs (will be copied)

`google_secure_source_manager_branch_rule`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1865 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1865 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 541 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_branch_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule" "primary" {
  allow_stale_reviews = # value needed
  disabled            = # value needed
  etag                = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_binding" "primary" {
  branch_rule_id = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  location      = # value needed
  members       = # value needed
  repository_id = # value needed
  role          = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_member" "primary" {
  branch_rule_id = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  location      = # value needed
  member        = # value needed
  repository_id = # value needed
  role          = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_policy" "primary" {
  branch_rule_id = # value needed
  location       = # value needed
  policy_data    = # value needed
  repository_id  = # value needed
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRuleIamBindingGenerated
• TestAccSecureSourceManagerBranchRuleIamMemberGenerated
• TestAccSecureSourceManagerBranchRuleIamPolicyGenerated
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRuleIamBindingGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRuleIamMemberGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRuleIamPolicyGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1865 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1865 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 541 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 242 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_branch_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule" "primary" {
  allow_stale_reviews = # value needed
  disabled            = # value needed
  etag                = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_binding" "primary" {
  branch_rule_id = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  location      = # value needed
  members       = # value needed
  repository_id = # value needed
  role          = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_member" "primary" {
  branch_rule_id = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  location      = # value needed
  member        = # value needed
  repository_id = # value needed
  role          = # value needed
}

Resource: google_secure_source_manager_branch_rule_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule_iam_policy" "primary" {
  branch_rule_id = # value needed
  location       = # value needed
  policy_data    = # value needed
  repository_id  = # value needed
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRuleIamBindingGenerated
• TestAccSecureSourceManagerBranchRuleIamMemberGenerated
• TestAccSecureSourceManagerBranchRuleIamPolicyGenerated
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRuleIamBindingGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRuleIamMemberGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRuleIamPolicyGenerated[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1108 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1108 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 149 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_branch_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_branch_rule" "primary" {
  allow_stale_reviews = # value needed
  disabled            = # value needed
  etag                = # value needed
}

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[slevenick]

Test failing with
resource_secure_source_manager_branch_rule_generated_test.go:41: Resource specified by ResourceName couldn't be found: google_secure_source_manager_branch_rule.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1116 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1116 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 149 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 261 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample[Error message] [Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1087 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1087 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample
• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleBasicExample[Debug log]
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1177 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1177 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• securesourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[sawaiba-s]

Test failing with resource_secure_source_manager_branch_rule_generated_test.go:41: Resource specified by ResourceName couldn't be found: google_secure_source_manager_branch_rule.

Tests are all passing.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1270 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1268 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1273 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1271 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[sawaiba-s]

🔴 Tests failed during RECORDING mode: TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@slevenick Do you have any ideas why this test is unable to find the branch rule after creation at the update step? Is it related to the lifecycle of resources in acceptance tests, and what changes do you recommend to improve this test setup?

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1336 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1334 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerBranchRule_secureSourceManagerBranchRuleWithFieldsExample_update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1334 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1334 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 260 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• securesourcemanager

🟢 All tests passed!

View the build log