From c5b0adbba6eb4c74aa9399a60269f06c9c11e946 Mon Sep 17 00:00:00 2001 From: Julia Matuszewska Date: Wed, 13 Nov 2024 14:07:00 +0000 Subject: [PATCH] Add PreApply to RepositoryGroup and CodeRepositoryIndex update tests --- mmv1/products/cloudaicompanion/RepositoryGroup.yaml | 2 +- .../resource_gemini_code_repository_index_test.go.tmpl | 6 ++++++ .../resource_gemini_repository_group_test.go.tmpl | 5 +++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/mmv1/products/cloudaicompanion/RepositoryGroup.yaml b/mmv1/products/cloudaicompanion/RepositoryGroup.yaml index 4ebc164f281a..86c315ce69ef 100644 --- a/mmv1/products/cloudaicompanion/RepositoryGroup.yaml +++ b/mmv1/products/cloudaicompanion/RepositoryGroup.yaml @@ -25,7 +25,7 @@ examples: - name: "gemini_repository_group_basic" min_version: 'beta' primary_resource_id: "example" - primary_resource_name: '"cri-1", fmt.Sprintf("tf-test-my-repo-group%s", context["random_suffix"])' + primary_resource_name: 'acctest.BootstrapSharedCodeRepositoryIndex(t, "basic-rg-test", "us-central1", "", ""), "test-rg-repository-group-id"' vars: repository_group_id: "example-repository-group-id" git_repository_link_id: 'example-git-repository-link-id' diff --git a/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_code_repository_index_test.go.tmpl b/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_code_repository_index_test.go.tmpl index a55f41cfd2d9..d3109b01d8c1 100644 --- a/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_code_repository_index_test.go.tmpl +++ b/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_code_repository_index_test.go.tmpl @@ -6,6 +6,7 @@ import ( "testing" "github.com/hashicorp/terraform-plugin-testing/helper/resource" + "github.com/hashicorp/terraform-plugin-testing/plancheck" "github.com/hashicorp/terraform-provider-google/google/acctest" ) @@ -31,6 +32,11 @@ func TestAccGeminiCodeRepositoryIndex_update(t *testing.T) { }, { Config: testAccGeminiCodeRepositoryIndex_update(context), + ConfigPlanChecks: resource.ConfigPlanChecks{ + PreApply: []plancheck.PlanCheck{ + plancheck.ExpectResourceAction("google_gemini_code_repository_index.example", plancheck.ResourceActionUpdate), + }, + }, }, { ResourceName: "google_gemini_code_repository_index.example", diff --git a/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_repository_group_test.go.tmpl b/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_repository_group_test.go.tmpl index f6e9a0415fbb..b20bd86d9a7c 100644 --- a/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_repository_group_test.go.tmpl +++ b/mmv1/third_party/terraform/services/cloudaicompanion/resource_gemini_repository_group_test.go.tmpl @@ -32,6 +32,11 @@ func TestAccGeminiRepositoryGroup_update(t *testing.T) { }, { Config: testAccGeminiRepositoryGroup_update(context), + ConfigPlanChecks: resource.ConfigPlanChecks{ + PreApply: []plancheck.PlanCheck{ + plancheck.ExpectResourceAction("google_gemini_repository_group.example", plancheck.ResourceActionUpdate), + }, + }, }, { ResourceName: "google_gemini_repository_group.example",