Skip to content

Commit da44fe8

Browse files
committed
Addressing auto-review comments and taking comments from previous PR #10193
1 parent 97fd550 commit da44fe8

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

appengine-java21/ee8/analytics/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
</parent>
3333

3434
<properties>
35-
<maven.compiler.target>1.8</maven.compiler.target>
36-
<maven.compiler.source>1.8</maven.compiler.source>
37-
<appengine.sdk.version>2.0.23</appengine.sdk.version>
35+
<maven.compiler.target>25</maven.compiler.target>
36+
<maven.compiler.source>25</maven.compiler.source>
37+
<appengine.sdk.version>3.0.1</appengine.sdk.version>
3838
</properties>
3939

4040
<dependencyManagement>

flexible/java-25/websocket-jetty/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ test against the Websocket server.
3737

3838
## Deploy
3939

40-
The sample application is packaged as a war, and hence will be automatically run
41-
using the [Java 8/Jetty 9 with Servlet 3.1
42-
Runtime](https://cloud.google.com/appengine/docs/flexible/java/dev-jetty9).
40+
The sample application is packaged as a jar and runs on the Java 25 runtime.
4341

4442
```sh
4543
mvn clean package appengine:deploy

flexible/java-25/websocket-jetty/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
</parent>
3535

3636
<properties>
37-
<maven.compiler.target>17</maven.compiler.target>
38-
<maven.compiler.source>17</maven.compiler.source>
37+
<maven.compiler.target>25</maven.compiler.target>
38+
<maven.compiler.source>25</maven.compiler.source>
3939
<failOnMissingWebXml>false</failOnMissingWebXml> <!-- REQUIRED -->
4040
<jetty.version>9.4.57.v20241219</jetty.version>
4141
<spring.boot.version>2.7.18</spring.boot.version>

flexible/java-25/websocket-jetty/src/main/java/com/example/flexible/websocket/jettynative/Main.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ private static void enableEmbeddedJspSupport(ServletContextHandler servletContex
104104
holderJsp.setInitParameter("logVerbosityLevel", "DEBUG");
105105
holderJsp.setInitParameter("fork", "false");
106106
holderJsp.setInitParameter("xpoweredBy", "false");
107-
holderJsp.setInitParameter("compilerTargetVM", "1.8");
108-
holderJsp.setInitParameter("compilerSourceVM", "1.8");
107+
holderJsp.setInitParameter("compilerTargetVM", "25");
108+
holderJsp.setInitParameter("compilerSourceVM", "25");
109109
holderJsp.setInitParameter("keepgenerated", "true");
110110
servletContextHandler.addServlet(holderJsp, "*.jsp");
111111
}

0 commit comments

Comments
 (0)