Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra]: Cancel previous PR workflow run on the same PR #2159

Open
Abacn opened this issue Jan 30, 2025 · 1 comment
Open

[Infra]: Cancel previous PR workflow run on the same PR #2159

Abacn opened this issue Jan 30, 2025 · 1 comment
Labels
addition New feature or request needs triage p2

Comments

@Abacn
Copy link
Contributor

Abacn commented Jan 30, 2025

Related Template(s)

N/A

What feature(s) are you requesting?

Currently when a PR has multiple commit, previous ones won't get cancelled. This wastes resources.

We should add concurrency group into the following GitHub Action workflows:

  • Java PR
  • Spanner PR
  • Kafka PR
@Abacn Abacn added addition New feature or request needs triage p2 labels Jan 30, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Jan 31, 2025

there is some logic here:

DataflowTemplates/.github/workflows/java-pr.yml

Line 46 in 7d257c9

group: ${{ github.workflow }}-${{ github.ref }}

but it won't cancel on new commit because of different "github.ref"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition New feature or request needs triage p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Abacn