Background

From @past on this PR

Can you guard against future schema changes via assertions or similar? It's better to not display any information if the schema has changed than to silently ingest unexpected data.

The data could lead to use returning things like this from the features API:

...
    {
      "feature_id": "features",
      "name": ""
    },
    {
      "feature_id": "groups",
      "name": ""
    },
    {
      "feature_id": "snapshots",
      "name": ""
    }
...

Definition of done

• Add a validate helper that is called inside the Parse method for the web feature data.json

  webstatus.dev/workflows/steps/services/web_feature_consumer/pkg/data/parser.go

  Lines 34 to 44 in 6f069fc

  	func (p Parser) Parse(in io.ReadCloser) (map[string]web_platform_dx__web_features.FeatureData, error) {
  	defer in.Close()
  	var ret map[string]web_platform_dx__web_features.FeatureData
  	decoder := json.NewDecoder(in)
  	err := decoder.Decode(&ret)
  	if err != nil {
  	return nil, errors.Join(ErrUnexpectedFormat, err)
  	}
  	return ret, nil
  	}

  • That validate method should do some additional checks to make sure the data is as expected. If not, return a new error.
    • At a minimum, it should check that the names for each feature is not empty.