Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the HUD counts towards FID #49

Open
rviscomi opened this issue May 6, 2020 · 2 comments
Open

Clicking the HUD counts towards FID #49

rviscomi opened this issue May 6, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@rviscomi
Copy link
Member

rviscomi commented May 6, 2020

Not sure how much we can do here, but this was unexpected. If we can't improve the DX it should at least be documented.

  1. Enable the HUD (overlay)
  2. Load a page
  3. Click anywhere in the HUD
  4. FID becomes final
@addyosmani addyosmani added the documentation Improvements or additions to documentation label May 6, 2020
@addyosmani
Copy link
Member

+1 to this being documented in the README. I anticipate developers could click on the HUD overlay for one of three reasons:

  1. Clicking Close
  2. Accidental click on one of the metrics
  3. Attempting to click something the overlay covers

Ideas for DX:

  • We could monitor clicks to anything inside the overlay. Either a message in the overlay or console could be shown to warn you ~ this click could have contributed to FID. Please reload.
  • I don't believe we're able to hoist the overlay outside of the main frame in any way that could desensitize FID to clicks inside it.

@tunetheweb
Copy link
Member

With the move towards INP this is maybe becoming less important?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants