Skip to content

Signpost TP costs nothing with matching class in inventory, not matching item #92

@Gaelmare

Description

@Gaelmare

The two checks in canPay:

if(now != null && now.getItem() !=null && now.getItem().getClass() == ClientConfigStorage.INSTANCE.getCost().getClass()){

and doPay:

player.inventory.clearMatchingItems(ClientConfigStorage.INSTANCE.getCost(), 0, stackSize, null);

Are not the same if the items are different only in an internal class map, e.g. TFC Powders:
https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/1.12.x/src/main/java/net/dries007/tfc/objects/items/ItemPowder.java

So canPay finds lapis powder in the inventory, but the payment item configured is "tfc:powder/kaolinite", so doPay finds nothing to clear, and the TP costs nothing.

Is Signpost still supported in 1.12?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugv1.0This issue is not relevant for the newest version and might well be never resolved.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions