Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Params URL not taken into account #459

Open
LazyDridri opened this issue Feb 19, 2025 · 4 comments
Open

[BUG] Params URL not taken into account #459

LazyDridri opened this issue Feb 19, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@LazyDridri
Copy link
Contributor

LazyDridri commented Feb 19, 2025

In functions.gd, parameters are not taken into account :

This :

function_task._url = url
if not params.is_empty():
url += "?"
for key in params.keys():
url += key + "=" + params[key] + "&"

Should be :
if not params.is_empty():
url += "?"
for key in params.keys():
url += key + "=" + params[key] + "&"

function_task._url = url

@LazyDridri LazyDridri added the bug Something isn't working label Feb 19, 2025
@WolfgangSenff
Copy link
Collaborator

Doh! Good find. Care to open a PR for it yourself, or do you want me to fix it?

@LazyDridri
Copy link
Contributor Author

I really don't know how to do this haha, I never worked with PR. But I can try

@WolfgangSenff
Copy link
Collaborator

Oh, it's fairly easy! You just fork the repository, make your changes, then on the site you can open the PR back against the this repo. I'll accept fairly quickly.

@LazyDridri
Copy link
Contributor Author

Alright let me try, I'll ask for help on discord if I struggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants