-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Params URL not taken into account #459
Labels
bug
Something isn't working
Comments
Doh! Good find. Care to open a PR for it yourself, or do you want me to fix it? |
I really don't know how to do this haha, I never worked with PR. But I can try |
Oh, it's fairly easy! You just fork the repository, make your changes, then on the site you can open the PR back against the this repo. I'll accept fairly quickly. |
Alright let me try, I'll ask for help on discord if I struggle |
LazyDridri
added a commit
to LazyDridri/GodotFirebase
that referenced
this issue
Feb 19, 2025
WolfgangSenff
pushed a commit
that referenced
this issue
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In functions.gd, parameters are not taken into account :
This :
function_task._url = url
if not params.is_empty():
url += "?"
for key in params.keys():
url += key + "=" + params[key] + "&"
Should be :
if not params.is_empty():
url += "?"
for key in params.keys():
url += key + "=" + params[key] + "&"
function_task._url = url
The text was updated successfully, but these errors were encountered: