This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Multi-stage Dockerfile for checkout service #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjrousos
approved these changes
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile for the checkout service runs
dotnet restorethen indiscriminately copies the build context. If there are restore assets in the build context, they overwrite those in the prior layer, causing the subsequent publish to fail because they reference paths on the local filesystem.This change cleans up the Dockerfile with a multi-stage build, solving this problem and producing a leaner final image.
Fixes #67