-
Notifications
You must be signed in to change notification settings - Fork 20
Connected client to api gateway; auth and checkout service working E2E #49
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
FROM node:latest | ||
LABEL Name=stickerapp-apigateway Version=0.1.0 | ||
COPY package.json /tmp/package.json | ||
RUN cd /tmp && npm install | ||
RUN mkdir -p /usr/src/app && mv /tmp/node_modules /usr/src | ||
WORKDIR /usr/src/app | ||
COPY . /usr/src/app | ||
EXPOSE 3000 | ||
CMD npm start |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,29 @@ | ||
'use strict'; | ||
|
||
var express = require('express'); | ||
var session = require('express-session'); | ||
var path = require('path'); | ||
var logger = require('morgan'); | ||
var cookieParser = require('cookie-parser'); | ||
var bodyParser = require('body-parser'); | ||
var passport = require('passport'); | ||
var authService = require('./services/auth'); | ||
var serverConnection = require('./config/database-config').serverConnection; | ||
|
||
var index = require('./routes/index'); | ||
var users = require('./routes/users'); | ||
var profile = require('./routes/profile'); | ||
var app = express(); | ||
const logger = require('morgan'); | ||
const cookieParser = require('cookie-parser'); | ||
const passport = require('passport'); | ||
const authService = require('./services/auth'); | ||
const serverConnection = require('./config/database-config').serverConnection; | ||
|
||
const users = require('./routes/users'); | ||
const browse = require('./routes/browse'); | ||
const cart = require('./routes/cart'); | ||
const feedback = require('./routes/feedback'); | ||
const create = require('./routes/create'); | ||
const checkout = require('./routes/checkout'); | ||
|
||
const app = express(); | ||
|
||
//TODO: Need to update this to correct path; need to take into account docker as well here | ||
const PROJECT_ROOT = path.join(__dirname, '..'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This path is incorrect for the given Docker configuration, and awkward in general. I think required files should be below the application in the tree. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch - I'm going to put a TODO comment above this line. I'd like to get all of the changes Mike made for docker in and then adjust this accordingly. |
||
app.set('etag', false); | ||
app.set('views', path.join(PROJECT_ROOT, 'apigateway', 'templates')); | ||
app.set('view engine', 'pug'); | ||
app.use(express.static(path.join(PROJECT_ROOT, 'client', 'dist'))); | ||
|
||
require('./strategy/aad-b2c')(); | ||
require('./strategy/passport')(); | ||
|
@@ -23,21 +35,31 @@ app.use(session({ | |
})); | ||
|
||
app.use(logger('dev')); | ||
app.use(bodyParser.json()); | ||
app.use(bodyParser.urlencoded({ extended: false })); | ||
app.use(cookieParser()); | ||
app.use(express.static(path.join(__dirname, 'public'))); | ||
|
||
app.use(passport.initialize()); | ||
app.use(passport.session()); | ||
|
||
app.use('/', index); | ||
app.use('/users', users); | ||
app.use('/profile', profile); | ||
|
||
// setup the auth's datastore where authenticated user\profile data is stored | ||
authService.setupAuthDataStore(); | ||
|
||
//All routes that do NOT require auth should be added here (prior to authService.verifyUserLoggedIn being added as a route) | ||
app.use('/users', users); | ||
app.use('/browse', browse); | ||
app.use('/cart', cart); //TODO: Will require auth | ||
app.use('/create', create); //TODO: Will require auth | ||
|
||
app.get('/', function stickerRootRedirection(req, res) { | ||
console.log('app.js: redirecting to browse'); | ||
res.redirect('/browse'); | ||
}); | ||
|
||
//Ensures that the user is authenticated prior to calling into routes | ||
//All routes requiring auth should be added after authService.verifyUserLoggedIn | ||
app.use(authService.verifyUserLoggedIn); | ||
app.use('/checkout', checkout); | ||
app.use('/feedback', feedback); | ||
|
||
const server = app.listen(serverConnection.port, () => { | ||
console.log(`Sticker server running on port ${server.address().port}`); | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
|
||
//Default URL for the checkout service which provides Feedback and Order CRUD operations | ||
checkoutServiceUrl: 'http://localhost:5000' | ||
}; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
'use strict'; | ||
|
||
//TODO: This functionality is temporary until integated with the new cart microservice; note that this currently calls into the "dummy" data access layer | ||
const express = require('express'); | ||
const bodyParser = require('body-parser'); | ||
const router = express.Router(); | ||
|
||
const dataAccess = require('../temp/db/data-access'); | ||
|
||
router.use(bodyParser.json()); | ||
|
||
router.get('/', function stickerRouteBrowse(req, res) { | ||
const renderData = { pageTitle: 'Browse', entry: 'browse' }; | ||
|
||
console.log('Render values: ', renderData); | ||
|
||
res.render('index', renderData); | ||
}); | ||
|
||
router.get('/api/items', function stickerRouteApiBrowse(req, res) { | ||
// Do things with req.query.tags | ||
let tags; | ||
if (req.query.tags) { | ||
tags = req.query.tags.split(','); | ||
} | ||
|
||
dataAccess.getStickers(tags, (items) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this something that will move into its own microservice eventually? I feel like doing data access for stickers from the API gateway muddies our microservice architecture and should be handled by a separate service. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, on my dev branch I've rewritten this to get data from the sticker service. |
||
console.info('%d stickers found', items.length); | ||
if (tags) { | ||
console.log('Tags used in filter: ', tags); | ||
} | ||
|
||
res.send({ | ||
items | ||
}); | ||
}); | ||
}); | ||
|
||
module.exports = router; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
'use strict'; | ||
|
||
//TODO: This functionality is temporary until integated with the new cart microservice; note that this currently calls into the "dummy" data access layer | ||
const express = require('express'); | ||
const bodyParser = require('body-parser'); | ||
const dataAccess = require('../temp/db/data-access'); | ||
|
||
const router = express.Router(); | ||
router.use(bodyParser.json()); | ||
|
||
router.get('/', function stickerRouteCart(req, res) { | ||
res.render('index', { pageTitle: 'Cart', entry: 'cart' }); | ||
}); | ||
|
||
function sendItems(token, res) { | ||
dataAccess.getCart(token, (items) => { | ||
dataAccess.getStickers(null, (stickers) => { | ||
res.send({ | ||
items: items.map((id) => stickers.filter((sticker) => sticker.id.toString() === id)[0]) | ||
}); | ||
}); | ||
}); | ||
} | ||
|
||
router.get('/api/items', (req, res) => { | ||
if (!req.query.token) { | ||
res.status(401).send('Unauthorized'); | ||
return; | ||
} | ||
sendItems(req.query.token, res); | ||
}); | ||
|
||
router.put('/api/items/:item_id', (req, res) => { | ||
if (!req.body.token) { | ||
res.status(401).send('Unauthorized'); | ||
return; | ||
} | ||
|
||
console.log('Item targetted %s', req.params.item_id); | ||
|
||
dataAccess.addToCart(req.body.token, req.params.item_id, () => { | ||
dataAccess.getSticker(req.params.item_id, (item) => { | ||
if (!item) { | ||
dataAccess.addStickers([ req.body.item ], () => sendItems(req.body.token, res)); | ||
} else { | ||
sendItems(req.body.token, res); | ||
} | ||
}); | ||
}); | ||
}); | ||
|
||
router.delete('/api/items/:item_id', (req, res) => { | ||
if (!req.body.token) { | ||
res.status(401).send('Unauthorized'); | ||
return; | ||
} | ||
|
||
console.log('Item targetted', req.params.item_id); | ||
|
||
dataAccess.removeFromCart(req.body.token, req.params.item_id, () => { | ||
sendItems(req.body.token, res); | ||
}); | ||
}); | ||
|
||
module.exports = router; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
|
||
'use strict'; | ||
|
||
//TODO: This is temporary using the "dummy" data access layer in order to interact with the cart; this will be removed when integrated with new cart microservice | ||
const dataAccess = require('../temp/db/data-access'); | ||
|
||
const express = require('express'); | ||
const request = require('request'); | ||
const guid = require('guid'); | ||
|
||
//This route calls into the ASP.NET Core checkout microservice | ||
const checkoutServiceUrl = require('../config/services-config').checkoutServiceUrl; //TODO: add env url lookup | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned in the TODO, we should prefer a URL from the environment since that will allow docker-compose files to organize services, as needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes agree - I am going to address this once Charles gets all the docker stuff checked in. |
||
|
||
const router = express.Router(); | ||
const bodyParser = require('body-parser'); | ||
router.use(bodyParser.urlencoded({ extended: true })); | ||
|
||
router.post('/', function stickerRouteCheckout(req, res) { | ||
|
||
var orderJson = { | ||
Id: guid.raw(), | ||
FullName : req.body['checkout-name'], | ||
Email : req.body['checkout-email'], | ||
Items : req.body['checkout-items'] | ||
}; | ||
|
||
request({ | ||
url: checkoutServiceUrl + '/api/order/', | ||
method: 'POST', | ||
json: true, | ||
body: orderJson, | ||
headers: { | ||
//Pass the current authenticated user's id to the checkout microservice | ||
'stickerUserId': req.user.id | ||
}}, | ||
function finishAddOrder(error){ | ||
if (error) { | ||
console.log('Adding Order failed: ' + error); | ||
} else { | ||
console.log('Order added'); | ||
} | ||
|
||
//TODO: Need to update this when the new cart microservice is integrated; for now, calls into the "dummy" data access layer | ||
dataAccess.clearCart(req.body.token, () => { | ||
res.render('index', { pageTitle: 'Checkout', entry: 'checkout' }); | ||
}); | ||
}); | ||
}); | ||
|
||
module.exports = router; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious: what's the advantage here over installing dependencies directly to
/usr/src
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I inadvertently included the docker files - I still have to finish this part of the check in before I have it reviewed. Also, I think Mike actually created this docker file and included it with his PR. Anyway, I will remove this file from this PR - you should add your comment to his.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied the Dockerfile Chris used for the web client. I agree that it seems like an unusual pattern; I'm not sure what the reasoning is.