Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Filter icon instead of 3 dots #2177

Closed
Huddie opened this issue Sep 23, 2018 · 22 comments
Closed

Filter icon instead of 3 dots #2177

Huddie opened this issue Sep 23, 2018 · 22 comments
Labels
🎨 design Changes to the design of the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase

Comments

@Huddie
Copy link
Collaborator

Huddie commented Sep 23, 2018

On the inbox page, the 3 dots (top left) allow for switching to a specific repo or view all. Maybe a filter icon is more appropriate

@BasThomas BasThomas added the 🎨 design Changes to the design of the app label Sep 24, 2018
@rnystrom
Copy link
Member

I dig it!

Sent with GitHawk

@rnystrom rnystrom added the ✨ good first issue An issue suitable for someone looking to get familiar with the codebase label Sep 24, 2018
@Huddie
Copy link
Collaborator Author

Huddie commented Sep 26, 2018

So I couldn't find a filter octicons so I went at making it myself.
Anyone have a better filter icon or suggestions to improve this one?

simulator screen shot - iphone xr - 2018-09-25 at 22 27 56

@Huddie
Copy link
Collaborator Author

Huddie commented Sep 26, 2018

My bad filling in the top. We seem to use outlined icons for navBar items

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Sep 27, 2018

Take 2
simulator screen shot - iphone xr - 2018-09-26 at 21 57 56

@Huddie
Copy link
Collaborator Author

Huddie commented Sep 28, 2018

Thoughts on improvements, or anyone have an icon ?

Sent with GitHawk

@rnystrom
Copy link
Member

Looks a little sharp on the edges. How about this one?

https://thenounproject.com/search/?q=Filter&i=1956576

Sent with GitHawk

@BasThomas
Copy link
Collaborator

There’s no icon at all in the latest beta here?

Sent with GitHawk

@rnystrom
Copy link
Member

rnystrom commented Sep 29, 2018

@BasThomas 😱 you’re right me neither! Where’d it go? Ha

Sent with GitHawk

@BasThomas
Copy link
Collaborator

No idea 😛

Sent with GitHawk

@Huddie Huddie mentioned this issue Sep 30, 2018
@Huddie
Copy link
Collaborator Author

Huddie commented Sep 30, 2018

@rnystrom I like the icon but I don’t have the ability to download it

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Oct 10, 2018

@rnystrom would you be able to add the icon to the project ?

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 25, 2018

Any interest in this still?

@kocheck
Copy link
Collaborator

kocheck commented Nov 25, 2018

@Huddie I can download and package that up for you ✌️

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 25, 2018

@kocheck thank you 😊

Sent with GitHawk

@rnystrom
Copy link
Member

Almost wondering if we should revisit some ideas for the inbox. One is maybe putting a drop down title and showing a menu with more per-repo options? I know folks really want the per-repo inbox (which is technically very complicated).

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

@kocheck if your free would you be interested in whipping up a few new inbox designs using what we have now + per-repo inbox + maybe issue Dashboard #2413 ?

Sent with GitHawk

@kocheck
Copy link
Collaborator

kocheck commented Nov 27, 2018

I would love to @Huddie !

I am not 100% sure how much time I can commit this week but I know I can start working up some sketches. Keep the conversation moving :)

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

@kocheck awesome. Take your time, should we create a new issue to inbox concepts/ideas?

@kocheck
Copy link
Collaborator

kocheck commented Nov 27, 2018

@Huddie Ya lets do that, Do you think over in the design repo would work?

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

Hmm. Not sure. Design repo is great for storing concepts etc but contributor traffic I feel is low. If we want to have a conversation about the new inbox I think GitHawk repo is the best place. @rnystrom would have a better sense

@kocheck
Copy link
Collaborator

kocheck commented Nov 27, 2018

Whatever works best honestly 😄 but a new issue would help keep things organized I think.

@Huddie Huddie mentioned this issue Nov 27, 2018
5 tasks
@BasThomas
Copy link
Collaborator

I'm going to close this as we do not have an icon to filter anymore, but a dropdown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎨 design Changes to the design of the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase
Projects
None yet
Development

No branches or pull requests

4 participants