Tabbar hide fix (#2509)

* Commented out line dealing with hiding bottombar

* Updated tests, removed commented out hidesBottomBar

* Fixed tests

* Fixed some warnings by swiftlint

Author: Huddie

Classes/View Controllers/SplitViewControllerDelegate.swift

@@ -32,7 +32,7 @@ final class SplitViewControllerDelegate: UISplitViewControllerDelegate {
             let secondaryNav = secondaryViewController as? UINavigationController {
 
             let collapsedControllers = secondaryNav.viewControllers.filter {
-                $0.hidesBottomBarWhenPushed = true
+
                 // remove any placeholder VCs from the stack
                 return ($0 is SplitPlaceholderViewController) == false
             }

FreetimeTests/SplitViewTests.swift

@@ -108,8 +108,22 @@ class SplitViewTests: XCTestCase {
         masterTab.selectedIndex = 1
 
         let detailNav = UINavigationController()
-        let detail1 = UIViewController()
-        let detail2 = UIViewController()
+
+        let detail1 = RepositoryViewController(
+            client: GithubClient(userSession: nil),
+            repo: RepositoryDetails(
+                owner: "Foo",
+                name: "Bar"
+        ))
+
+        let detail2 = IssuesViewController(
+            client: GithubClient(userSession: nil),
+            model: IssueDetailsModel(
+                owner: "Foo",
+                repo: "Bar",
+                number: 0
+        ))
+
         detailNav.pushViewController(detail1, animated: false)
         detailNav.pushViewController(detail2, animated: false)
 
@@ -131,8 +145,13 @@ class SplitViewTests: XCTestCase {
 
         XCTAssertFalse(rightNav.viewControllers[0].hidesBottomBarWhenPushed)
         XCTAssertFalse(rightNav.viewControllers[1].hidesBottomBarWhenPushed)
-        XCTAssertTrue(rightNav.viewControllers[2].hidesBottomBarWhenPushed)
+
+        // RepositoryViewController should not hide bottom bar
+        XCTAssertTrue(!rightNav.viewControllers[2].hidesBottomBarWhenPushed)
+
+        // IssueViewController should not hide bottom bar
         XCTAssertTrue(rightNav.viewControllers[3].hidesBottomBarWhenPushed)
+
     }
 
     func test_whenCollapsing_withPlaceholderStackedOnDetail_thatVCsStackedWithoutPlaceholder() {