Skip to content

Use navigation bar appearance in GalleryHeaderView #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Use navigation bar appearance in GalleryHeaderView #942

merged 1 commit into from
Sep 9, 2025

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

Related: IOS-1118

🎯 Goal

GalleryHeaderView is a custom view which looks like a navigation bar, but it actually is not

📝 Summary

🛠 Implementation

🎨 Showcase

Default Custom
Screenshot 2025-09-09 at 12 34 55 Screenshot 2025-09-09 at 12 19 49

🧪 Manual Testing Notes

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus requested a review from a team as a code owner September 9, 2025 09:37
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.26 MB 9.27 MB +2 KB 🟢

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2025

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2025

Public Interface

🚀 No changes affecting the public interface.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nuno-vieira
nuno-vieira approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@laevandus laevandus merged commit 44b22f5 into develop Sep 9, 2025
11 checks passed
@laevandus laevandus deleted the gallery-header-appearance branch September 9, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laevandus @Stream-SDK-Bot @nuno-vieira