Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Attack On Hero 2 #118

Open
pr0crustes opened this issue Feb 1, 2019 · 1 comment
Open

[SCHEMA] Attack On Hero 2 #118

pr0crustes opened this issue Feb 1, 2019 · 1 comment
Assignees

Comments

@jimmydorry jimmydorry self-assigned this Feb 1, 2019
@jimmydorry
Copy link
Member

I would suggest renaming your schema fields into something more compact:

  • gt
  • gr
  • aa
  • ph
  • pd
  • pl
  • pi

Also, you should round game time to the nearest second. You aren't going to get much value out of 10 significant digits (after the decimal point).

I don't remember how Booleans (your anicent_alive variable) are handled. If the schema doesn't work, you will want to convert the Boolean to a number or string: e.g. 'True' or 1 or 'Yes'. You should probably be fine though.

Here's your schema, please review the modified fields.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=588

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with N7K... not a v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants