conformance: each RED arm is its own test (plugin-gates bothways)

Author: MattJackson

store-postgres-plugin/tests/conformance.rs

@@ -17,7 +17,7 @@
 //!   tests use: unset under CI is a FAILURE, unset locally skips only this scenario), one durable
 //!   scenario per door — upsert, point read, a child chain, single-use token redemption, delete.
 //!
-//! RED ARMS, in the same test and always run (no database needed): the library asked for as
+//! RED ARMS, each its own test and always run (no database needed): the library asked for as
 //! `kind: secret` is refused before any slot is called, and DIFFERENT bytes (the cdylib with its
 //! object magic broken) are not the store — so the comparison above cannot pass vacuously.
 
@@ -137,31 +137,11 @@ fn transcript(
     })
 }
 
-/// The Postgres store behaves as ONE store through either door — and the RED arms show the
-/// comparison is not vacuous.
+/// The Postgres store behaves as ONE store through either door (the RED arms are their own tests
+/// below, so the comparison is not vacuous).
 #[test]
 fn the_linked_and_the_dropped_in_postgres_store_are_one_store() {
     let live = live_url();
-    let lib = common::cdylib();
-
-    // RED ARM 1 — RUN FIRST: DIFFERENT bytes (the object's magic broken) are not the store. It must
-    // run before ANY good image is loaded from a path the loader may have mapped already.
-    let mut foreign = std::fs::read(&lib).expect("read the cdylib");
-    foreign[..4].copy_from_slice(b"XXXX");
-    let dir = std::env::temp_dir().join(format!("store-postgres-conf-{}", std::process::id()));
-    let _ = std::fs::remove_dir_all(&dir);
-    std::fs::create_dir_all(&dir).unwrap();
-    let broken = dir.join(lib.file_name().unwrap());
-    std::fs::write(&broken, &foreign).unwrap();
-    let red = match common::dropped_at(&broken, "{}") {
-        Ok(_) => panic!("foreign bytes opened as the store"),
-        Err(e) => e,
-    };
-    assert!(
-        !red.contains("requires a \"url\""),
-        "foreign bytes cannot speak the store's own refusal: {red}"
-    );
-
     let linked = transcript("linked", &common::linked, live.as_deref());
     let dropped_in = transcript("dropped", &common::dropped, live.as_deref());
     assert_eq!(linked, dropped_in, "the two doors are not one store");
@@ -197,8 +177,38 @@ fn the_linked_and_the_dropped_in_postgres_store_are_one_store() {
             })
         );
     }
+}
+
+/// RED ARM 1: DIFFERENT bytes (the object's magic broken) are not the store, so the both-ways
+/// comparison cannot pass vacuously. The broken image is its own file in its own directory, so it
+/// is never a path a good image was mapped from. No database needed.
+#[test]
+fn a_cdylib_with_broken_magic_is_not_the_store() {
+    let lib = common::cdylib();
+    let mut foreign = std::fs::read(&lib).expect("read the cdylib");
+    foreign[..4].copy_from_slice(b"XXXX");
+    let dir =
+        std::env::temp_dir().join(format!("store-postgres-conf-broken-{}", std::process::id()));
+    let _ = std::fs::remove_dir_all(&dir);
+    std::fs::create_dir_all(&dir).unwrap();
+    let broken = dir.join(lib.file_name().unwrap());
+    std::fs::write(&broken, &foreign).unwrap();
+    let red = match common::dropped_at(&broken, "{}") {
+        Ok(_) => panic!("foreign bytes opened as the store"),
+        Err(e) => e,
+    };
+    assert!(
+        !red.contains("requires a \"url\""),
+        "foreign bytes cannot speak the store's own refusal: {red}"
+    );
+    let _ = std::fs::remove_dir_all(&dir);
+}
 
-    // RED ARM 2: the store's library asked for as another kind is refused before any slot runs.
+/// RED ARM 2: the store's library asked for as another kind is refused before any slot runs. No
+/// database needed.
+#[test]
+fn a_store_library_loaded_as_another_kind_is_refused() {
+    let lib = common::cdylib();
     let d = Arc::new(Dispatcher::new(DispatchConfig::default()));
     let bind = Bind {
         instance: Arc::from("store-postgres-as-secret"),
@@ -211,5 +221,4 @@ fn the_linked_and_the_dropped_in_postgres_store_are_one_store() {
         load_dropped::<Secret>(&lib, &common::stated(), bind).is_err(),
         "a store library loaded as kind secret"
     );
-    let _ = std::fs::remove_dir_all(&dir);
 }