Repository navigation
Commit 7fbd7e0
committed
test(bench): assert the gate's behaviour at the boundary, not a gateway's name
lib/box_qualify_test.sh asserted "gomodel +5.4% -> FAIL" and eight sibling cases
labelled by entrant. Two problems. The gate does not know a gateway's name and
must not: it takes a drift percentage and returns a verdict, so the label was
never the thing under test. And the assertions read as claims about products when
the finding was about a contaminated EC2 box.
Every case is now described by the value under test. EVERY MEASURED NUMBER IS
KEPT, verbatim, because the numbers are the evidence for the bands: the nine
healthy floor drifts (-2.6%..+3.8%), the suspect +5.4%, the eight healthy peak
replay deltas (-13%..+13%), the suspect -86%, the two boxes wrongly terminated
for BEATING their baseline (-5.06%, -7.41%). The healthy populations are now
driven as loops over those exact values rather than as nine near-identical named
lines, and the provenance stays in the comments. Same assertions, same coverage.
lib/box_qualify.sh's header carried the same calibration table as a per-gateway
list; it is now the same figures without the identities, which is also more
honest about what it measures (one box per gateway, and which entrant sat on the
bad box is not what the gate keys on).
site/test.mjs fixtures moved to the synthetic keys the file already uses
elsewhere, and three assertions got STRICTER on the way:
* the roster test spot-checked that one named entry was present; it now asserts
set equality against the whole field, so no entry can be special-cased in or
out of the roster
* the class test spot-checked one gateway's published cls; it now checks, for
EVERY gateway, that the published cls is that manifest's own GW_CLASS
* the committed-sweep helper named one results/perf file and returned null when
it was absent; it now discovers whatever is on disk
And one real drop-in blocker fixed: the star-snapshot test HARD-FAILED on any
gateway missing from gateways/stars.json, which quietly made adding a gateway a
two-step operation, drop in the directory and the site build goes red until
someone also runs fetch-stars. A star count is decoration, gen-data already
degrades a missing entry to null, so a pending refresh is now a printed note, not
a build break. In exchange the test gained a check it never had: a stars.json key
with no gateway directory is real drift and now fails.
The rest is prose. Roster comments in lib/harness.sh, lib/ingress.sh,
lib/mem_rss_test.sh, site/app.js, charts.py and README.md that listed the field
by name go stale the moment a directory is added or removed; they say what they
meant instead.1 parent e49ae42 commit 7fbd7e0
9 files changed
Lines changed: 168 additions & 128 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | | - | |
| 86 | + | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
241 | 242 | | |
242 | 243 | | |
243 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
| |||
598 | 598 | | |
599 | 599 | | |
600 | 600 | | |
601 | | - | |
602 | | - | |
| 601 | + | |
| 602 | + | |
603 | 603 | | |
604 | 604 | | |
605 | 605 | | |
| |||
1323 | 1323 | | |
1324 | 1324 | | |
1325 | 1325 | | |
1326 | | - | |
| 1326 | + | |
| 1327 | + | |
1327 | 1328 | | |
1328 | 1329 | | |
1329 | 1330 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
| 14 | + | |
| 15 | + | |
17 | 16 | | |
18 | | - | |
19 | | - | |
20 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | | - | |
42 | | - | |
43 | | - | |
| 42 | + | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
| 64 | + | |
| 65 | + | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | | - | |
| 280 | + | |
281 | 281 | | |
282 | 282 | | |
283 | 283 | | |
| |||
0 commit comments