Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Archiver extension #1426

Closed
3 of 11 tasks
avdata99 opened this issue Mar 2, 2020 · 1 comment
Closed
3 of 11 tasks

Upgrade Archiver extension #1426

avdata99 opened this issue Mar 2, 2020 · 1 comment

Comments

@avdata99
Copy link
Contributor

avdata99 commented Mar 2, 2020

Description

In the catalog-app we are using a fork of the official ckanext-archiver extension (on the datagov branch).

As a part of a plan to upgrade CKAN extensions in use, and in order to improve the way that we manage forks we need to upgrade this extension.

Acceptance Criteria

  • When there's a new release upstream, we can get onto it in under an hour
  • When there's a new release upstream, we see a notification in a Slack channel
  • If the upstream maintainers don't already use versioning, there's an issue in their tracker requesting they do.
  • If the upstream maintainers don't already have tests, there's an issue in their tracker requesting they add them.
  • We have tests for this extension running in CI. Done here if we use upstream

Tasks

  • Create a test environment with the catalog-app
  • Test this extension
  • Upstream do not use tags for versions, do not have a change log file and version is 2.0.0 since 4 years ago. Ask upstream for improve versioning: Done
  • Measure the effort to move the catalog-app to this official archiver version.
  • Check if the custom broken link functionality is required. If it is, look into pulling some, or all, of the GSA code related to this upstream.
  • Check if the bulk update code is required. If it is, look into pulling some, or all, of the GSA code related to this upstream.

The official repo has tests and CI. It is an active repo.

Analysis & notes

There are 2 main differences between the GSA fork and upstream. The first is a custom implementation of displaying whether a link is broken, on the package page itself. This is something that’s listed as TODO upstream, so we might be able to use some of this code there. The second change is a custom bulk resource update function. Some of this might also be useful upstream.

Our fork is Ahead in 43 commits and behind 69 commits. These links show us the changes between our datagov branch and master at upstream.

Recommendations

We recommend to move to the community version.

@nickumia-reisys
Copy link
Contributor

We are using the upstream version of archiver, but there are some issues with production,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants