Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should fail when parameteres are not set #279

Open
joker234 opened this issue Jul 20, 2022 · 0 comments
Open

Tests should fail when parameteres are not set #279

joker234 opened this issue Jul 20, 2022 · 0 comments
Labels
bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.)

Comments

@joker234
Copy link
Member

Bug Description

If you run the tests in the ohsome API project you don't get any errors if you didn't pass the required parameters.

General Information

Please include the following general information about the issue and list any additional steps needed to reproduce the bug.

  • Version of the ohsome API [e.g. 1.5.0]: current master

Expected Behaviour

The tests shouldn't be ignored but fail. In the maven output you can't even see that tests were skipped!

Output

IDEA

Maven

% JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 mvn clean test
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< org.heigit.ohsome:ohsome-api >--------------------
[INFO] Building ohsome API 1.7.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
…
[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ ohsome-api ---
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.heigit.ohsome.ohsomeapi.executor.ContributionsExecutorTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.048 s - in org.heigit.ohsome.ohsomeapi.executor.ContributionsExecutorTest
[INFO] Running org.heigit.ohsome.ohsomeapi.controller.DataExtractionTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s - in org.heigit.ohsome.ohsomeapi.controller.DataExtractionTest
[INFO] Running org.heigit.ohsome.ohsomeapi.controller.PostControllerTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.heigit.ohsome.ohsomeapi.controller.PostControllerTest
[INFO] Running org.heigit.ohsome.ohsomeapi.controller.GetControllerTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.heigit.ohsome.ohsomeapi.controller.GetControllerTest
[INFO] Running org.heigit.ohsome.ohsomeapi.inputprocessing.InputProcessingUtilsTest
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.052 s - in org.heigit.ohsome.ohsomeapi.inputprocessing.InputProcessingUtilsTest
[INFO] Running org.heigit.ohsome.ohsomeapi.inputprocessing.GeometryBuilderTest
Jul 20, 2022 6:09:27 PM org.hsqldb.persist.Logger logInfoEvent
INFO: dataFileCache open start
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.244 s - in org.heigit.ohsome.ohsomeapi.inputprocessing.GeometryBuilderTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.023 s
[INFO] Finished at: 2022-07-20T18:09:28+02:00
[INFO] ------------------------------------------------------------------------
@joker234 joker234 added bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.) labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.)
Projects
None yet
Development

No branches or pull requests

1 participant