Fixes for Tioga Compiler Warnings (#297)

Author: wrtobin

host-configs/LLNL/tioga-cce-15.cmake

@@ -27,7 +27,7 @@ set(CMAKE_Fortran_COMPILER "/opt/cray/pe/craype/${CRAYPE_VERSION}/bin/ftn" CACHE
 if( ENABLE_HIP )
   set( ENABLE_CLANG_HIP ON CACHE BOOL "" FORCE )
 
-  set( HIP_VERSION_STRING "5.4.0" CACHE STRING "" )
+  set( HIP_VERSION_STRING "5.4.3" CACHE STRING "" )
   set( HIP_ROOT "/opt/rocm-${HIP_VERSION_STRING}" CACHE PATH "" )
   set( ROCM_PATH ${HIP_ROOT} CACHE PATH "" )
 

src/ChaiBuffer.hpp

@@ -183,6 +183,8 @@ class ChaiBuffer
   {
   #if defined(LVARRAY_DEVICE_COMPILE)
     LVARRAY_ERROR( "Creating a new ChaiBuffer on device is not supported." );
+    LVARRAY_UNUSED_VARIABLE( spaces );
+    LVARRAY_UNUSED_VARIABLE( allocators );
   #else
     m_pointerRecord->m_size = 0;
     setName( "" );
@@ -308,10 +310,15 @@ class ChaiBuffer
    * @note Although it is marked as a host-device method, this is only valid to call from the host.
    */
   LVARRAY_HOST_DEVICE
-  void reallocate( std::ptrdiff_t const size, MemorySpace const space, std::ptrdiff_t const newCapacity )
+  void reallocate( std::ptrdiff_t const size,
+                   MemorySpace const space,
+                   std::ptrdiff_t const newCapacity )
   {
   #if defined(LVARRAY_DEVICE_COMPILE)
     LVARRAY_ERROR( "Allocation from device is not supported." );
+    LVARRAY_UNUSED_VARIABLE( size );
+    LVARRAY_UNUSED_VARIABLE( space );
+    LVARRAY_UNUSED_VARIABLE( newCapacity );
   #else
     move( space, true );
     chai::PointerRecord * const newRecord = new chai::PointerRecord{};

src/Macros.hpp

@@ -66,8 +66,6 @@
  */
 #define STRINGIZE( A ) STRINGIZE_NX( A )
 
-//#pragma message "LVARRAY_DEVICE_COMPILE: " STRINGIZE(LVARRAY_DEVICE_COMPILE)
-
 /**
  * @brief Mark @p X as an unused argument, used to silence compiler warnings.
  * @param X the unused argument.
@@ -123,7 +121,11 @@
  */
 
 #if defined(LVARRAY_DEVICE_COMPILE)
-  #if !defined(NDEBUG) || __HIP_DEVICE_COMPILE__ == 1
+//   #if defined(__HIP_DEVICE_COMPILE__)
+// // empty impl to avoid the possibility of printfs in device code
+// //   on AMD, which can cause performance degradation just by being present
+// #define LVARRAY_ERROR_IF( EXP, MSG )
+  #if (!defined(NDEBUG)) || defined(__HIP_DEVICE_COMPILE__)
 #define LVARRAY_ERROR_IF( EXP, MSG ) \
   do \
   { \