Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce unencoded WriteBatch #98

Open
Fullstop000 opened this issue Nov 27, 2020 · 0 comments
Open

Introduce unencoded WriteBatch #98

Fullstop000 opened this issue Nov 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Fullstop000
Copy link
Owner

Currently, the WriteBatch follows the original implementation of leveldb, which is a Vec<u8> with encoded entries. When we call put, the entry will be encoded into variant length based encoded bytes, fill the bytes into a WriteBatch and then be inserted into MemTable, However, when inserting the batch into MemTable, it needs to be decoded into entires first.

For a more efficient inserting style, we might just let WriteBatch hold unencoded entries, and deliver them to the MemTable without any serde.

@Fullstop000 Fullstop000 added the enhancement New feature or request label Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant