Remove duplicate data, add url to SeriesWorkSummary

Author: hkamran80

src/series/getters.ts

@@ -1,7 +1,7 @@
 import { Author, Series, SeriesWorkSummary } from "types/entities";
 import { SeriesPage, WorkPage } from "../page-loaders";
 import { CheerioAPI, load } from "cheerio";
-import { getWorkDetailsFromUrl } from "src/urls";
+import { getWorkDetailsFromUrl, getWorkUrl } from "src/urls";
 import {
   getWorkBookmarkCount,
   getWorkHits,
@@ -136,9 +136,11 @@ const getSeriesWork = (workHtml: string): SeriesWorkSummary => {
   const publishedChapters = getWorkPublishedChapters($$work);
 
   const url = $work("a[href*='/works/']").attr("href") as string;
+  const id = getWorkDetailsFromUrl({ url }).workId
 
   return {
-    id: getWorkDetailsFromUrl({ url }).workId,
+    id,
+    url: getWorkUrl({ workId: id }),
     title: getSeriesWorkTitle($work),
     updatedAt: getSeriesWorkUpdateDate($work),
 

src/series/index.ts

@@ -13,7 +13,6 @@ import {
   getSeriesWorkCount,
   getSeriesWorks,
 } from "./getters";
-import { getWorkUrl } from "src/urls";
 
 export const getSeries = async ({
   seriesId,
@@ -37,7 +36,5 @@ export const getSeries = async ({
     complete: getSeriesCompletionStatus(seriesPage),
     workCount: getSeriesWorkCount(seriesPage),
     works: seriesWorks,
-    workTitles: seriesWorks.map((work) => work.title),
-    workUrls: seriesWorks.map((work) => getWorkUrl({ workId: work.id })),
   };
 };

types/entities.ts

@@ -43,6 +43,7 @@ export interface SeriesWorkSummary
     WorkSummary,
     "category" | "publishedAt" | "rating" | "tags" | "stats" | "locked"
   > {
+  url: string;
   tags: Omit<WorkSummary["tags"], "warnings">;
   stats: Omit<WorkSummary["stats"], "comments">;
 }
@@ -58,11 +59,8 @@ export interface Series {
   words: number;
   bookmarks: number;
   complete: boolean;
-
   workCount: number;
   works: SeriesWorkSummary[];
-  workTitles: string[]
-  workUrls: string[]
 }
 
 export enum WorkRatings {