Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update output_asset_to() and output_asset_id() to handle Output::Variable #6781

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update output_asset_to() and output_asset_id() to handle Output::Variable #6781

wants to merge 4 commits into from
+144 −51

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Dec 9, 2024 •
edited
Loading

Description

Allows for fetching of the AssetId and the to Address from an Output::Variable.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added enhancement New feature or request lib: std Standard library labels Dec 9, 2024
@bitzoic bitzoic self-assigned this Dec 9, 2024
@bitzoic bitzoic changed the title Get AssetId from Output::Variable Update output_asset_to() and output_asset_id() to handle Output::Variable Dec 10, 2024
@bitzoic bitzoic marked this pull request as ready for review December 10, 2024 12:46
@bitzoic bitzoic requested review from a team as code owners December 10, 2024 12:46
K1-R1
K1-R1 approved these changes Dec 10, 2024
View reviewed changes
sway-lib-std/src/outputs.sw
@@ -228,6 +228,10 @@ pub fn output_asset_id(index: u64) -> Option<AssetId> {
match output_type(index) {
Some(Output::Coin) => Some(AssetId::from(__gtf::<b256>(index, GTF_OUTPUT_COIN_ASSET_ID))),
Some(Output::Change) => Some(AssetId::from(__gtf::<b256>(index, GTF_OUTPUT_COIN_ASSET_ID))),
Some(Output::Variable) => {
let ptr = output_pointer(index).unwrap();
Some(AssetId::from(ptr.add_uint_offset(48).read::<b256>()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth adding a small comment explaining the use of 48 or having it as a constant?
Will leave to author's choice as I'm unsure if necessary

@K1-R1 K1-R1 requested a review from a team December 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bitzoic bitzoic

Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitzoic @K1-R1