Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to check that the contract_id field is right in the Panic #256

Open
xgreenx opened this issue Nov 1, 2022 · 2 comments
Open

Add unit test to check that the contract_id field is right in the Panic #256

xgreenx opened this issue Nov 1, 2022 · 2 comments
Assignees
@Dentosal
Labels
fuel-vm Related to the `fuel-vm` crate. tech-debt

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 1, 2022

Add unit tests to catch #255
@Voxelot
Copy link
Member

Voxelot commented Nov 1, 2022

We should also verify the behavior in other opcodes besides call

@xgreenx
Copy link
Collaborator Author

xgreenx commented Nov 3, 2022

During testing with SDK, we found that ra doesn't work for some opcodes, so we did a temporary no-breaking change #261. I added that comment for history.

We still need to test all possible opcodes and maybe start supporting the ContractId meta information not only for the ContractNotInInputs error.

@mitchmindtree mitchmindtree added the fuel-vm Related to the `fuel-vm` crate. label Dec 9, 2022
@tkporter tkporter mentioned this issue Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dentosal Dentosal

Labels
fuel-vm Related to the `fuel-vm` crate. tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Voxelot @Dentosal @mitchmindtree @xgreenx