Add preconfirmation gossip messages #2726
Open
+2,230
−1,857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
commented
Feb 19, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn run__gossip_message_from_p2p_service_is_broadcasted__tx_confirmations() { |
There was a problem hiding this comment.
This is the only new test in this file. The rest were just copied over during the refactor.
MitchTurner
commented
Feb 19, 2025
|
|
||
| #[tokio::test] | ||
| #[instrument] | ||
| async fn gossipsub_broadcast_tx_with_reject__tx_confirmations() { |
MitchTurner
commented
Feb 19, 2025
|
|
||
| #[tokio::test] | ||
| #[instrument] | ||
| async fn gossipsub_broadcast_tx_with_accept__tx_confirmations() { |
MitchTurner
commented
Feb 19, 2025
|
|
||
| // TODO: Move me before tests that use this function | ||
| /// Reusable helper function for Broadcasting Gossipsub requests | ||
| async fn gossipsub_broadcast( |
There was a problem hiding this comment.
This method was updated to accept the new GossipsubBroadcastRequest::Confirmations variant.
Introduced check_message_matches_request as part of that (before it was hardcoded to look for a specific value).
MitchTurner
changed the title
TxConfirmation gossip messages
MitchTurner
requested review from
acerone85,
rafal-ch,
rymnc and
AurelienFT
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2738
Description
This is part of the greater tx confirmation work. This will enable the block producer to gossip a batch of signed transactions around the network for the senders of those transactions to receive.
In an attempt to cleanup the P2P code, some of the tests were moved to their own files (this makes reviewing slightly more difficult, so I've marked the new tests with comments in those refactored test suites).
TODO:
TxConfirmationstypesignature?txs?Constrain peers for gossiping to minimize trafficAllow nodes to specify with whom they want to gossip Preconfirmations #2740Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]