Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM block production can fail if new fuel-core supports new types of blocks/transactions #2679

Open
xgreenx opened this issue Feb 7, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 7, 2025

If we add new types like BlockV2 or a new type of transaction, the old WASM code can't deserialize them.

The current WASM executor will ruin the whole block during production if one of the transactions is new.

We must teach the WASM executor to deserialize transactions individually and discard unserializable transactions.

@xgreenx xgreenx added the bug Something isn't working label Feb 7, 2025
@MitchTurner
Copy link
Member

and discard unserializable transactions.

This seems dangerous and will result in a fork. Don't we want to fail/stop if there is something it can't deserialize?

@MitchTurner
Copy link
Member

@xgreenx I think we should discuss the desired behavior here more ^^^

@xgreenx
Copy link
Collaborator Author

xgreenx commented Feb 13, 2025

It will not cause a fork, because it is logic on the block producer side, not validation side. Validation still should fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants