feat: optimize HexString to use Cow<[u8]> for efficient memory usage #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderfan
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
|
Thanks for the contribution! Before we can merge this, we need @wonderfan to sign the Fuel Labs Contributor License Agreement. |
|
thanks for your PR @wonderfan :) please let us know what you need from us |
rymnc
reviewed
Feb 6, 2025
| Ok(fuel_types::Nonce::from(bytes)) | ||
| } | ||
| } | ||
|
|
||
| // Additional convenience methods | ||
| impl HexString { | ||
| pub fn as_bytes(&self) -> &[u8] { |
There was a problem hiding this comment.
Suggested change
| pub fn as_bytes(&self) -> &[u8] { | |
| /// View the HexString as a byte array. | |
| pub fn as_bytes(&self) -> &[u8] { |
| self.0.as_ref() | ||
| } | ||
|
|
||
| pub fn into_owned(self) -> Vec<u8> { |
There was a problem hiding this comment.
Suggested change
| pub fn into_owned(self) -> Vec<u8> { | |
| /// Extracts the owned data. | |
| /// Clones the data if it is not already owned. | |
| pub fn into_owned(self) -> Vec<u8> { |
| self.0.into_owned() | ||
| } | ||
|
|
||
| pub fn from_static(bytes: &'static [u8]) -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn from_static(bytes: &'static [u8]) -> Self { | |
| /// Convert a static byte array to a HexString. | |
| pub fn from_static(bytes: &'static [u8]) -> Self { |
|
@rymnc I try to optimize the codes, but it introduces other side effects after tests. As a result, i close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this change set to fix #2657
Linked Issues/PRs
Description
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]